Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(common): calculate already-build dependency targets correctly
When using module:target style dependencies, Builder would not track the individual targets within the module, causing only the first target to be built; subsequent dependency targets within that module would be treated as already built. This change means that builder will track individual targets within the dependency. However, it is possible for targets to be built multiple times if there a dependency listed for the entire module as well as for the individual target within dependency, as in the following example, where building project1 and project2 in one command would cause module:mytarget to be built twice. builder_describe project1 \ @/module builder_describe project2 \ @/module:mytarget This scenario should not break builds as they any configure+build actions should be idempotent, but it could cause builds to be a little slower, so should be corrected if identified. I do not currently plan to further modify the dependency calculations to cater for this scenario. Finally, if :mytarget is a child build, it is better to reference the child module directly than the parent's target, for example: builder_describe projec1 \ @/module/mytarget
- Loading branch information