Skip to content

Commit

Permalink
chore(developer): update per code review
Browse files Browse the repository at this point in the history
- fixes to build.sh and package.json

Co-authored-by: Marc Durdin <[email protected]>
  • Loading branch information
srl295 and mcdurdin committed Dec 6, 2024
1 parent a953546 commit a1e73a5
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 27 deletions.
30 changes: 8 additions & 22 deletions developer/src/vscode-plugin/build.sh
Original file line number Diff line number Diff line change
Expand Up @@ -11,37 +11,23 @@ THIS_SCRIPT="$(readlink -f "${BASH_SOURCE[0]}")"
. "$KEYMAN_ROOT/resources/shellHelperFunctions.sh"

builder_describe "Keyman Developer for VSCode module" \
"clean" \
"configure" \
"build" \
"clean" \
"test"
"test" \
"api" \
"publish"

builder_describe_outputs \
configure /node_modules \
build /developer/src/vscode-plugin/out/extension.js

builder_parse "$@"

function do_clean() {
rm -rf ./out/ ./tsconfig.tsbuildinfo .vscode-test
}

function do_configure() {
verify_npm_setup
}

function do_build() {
npm run compile
}

function do_test() {
npm test
}

builder_run_action clean do_clean
builder_run_action configure do_configure
builder_run_action build do_build
builder_run_action test do_test
builder_run_action clean rm -rf ./out/ ./tsconfig.tsbuildinfo .vscode-test
builder_run_action configure verify_npm_setup
builder_run_action build npm run compile
builder_run_action test npm test

#-------------------------------------------------------------------------------------------------------------------

Expand Down
10 changes: 5 additions & 5 deletions developer/src/vscode-plugin/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -51,10 +51,10 @@
},
"license": "MIT",
"dependencies": {
"@keymanapp/common-types": "file:../../../common/web/types",
"@keymanapp/developer-utils": "file:../common/web/utils",
"@keymanapp/kmc-kmn": "file:../kmc-kmn",
"@keymanapp/kmc-ldml": "file:../kmc-ldml",
"@keymanapp/kmc-package": "file:../kmc-package"
"@keymanapp/common-types": "*",
"@keymanapp/developer-utils": "*",
"@keymanapp/kmc-kmn": "*",
"@keymanapp/kmc-ldml": "*",
"@keymanapp/kmc-package": "*"
}
}

0 comments on commit a1e73a5

Please sign in to comment.