fix(ios): writeKeyboardHeightIfDoesNotExist logic error

keymanapp · Dec 9, 2024 · b1d23b2 · b1d23b2
1 parent c9d4c5c
commit b1d23b2
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/ios/engine/KMEI/KeymanEngine/Classes/Keyboard/InputViewController.swift b/ios/engine/KMEI/KeymanEngine/Classes/Keyboard/InputViewController.swift
@@ -174,7 +174,6 @@ open class InputViewController: UIInputViewController, KeymanWebDelegate {
   }
 
   open class var topBarHeight: CGFloat {
-    os_log("topBarHeight", log:KeymanEngineLogger.ui, type: .info)
     let scaling = KeyboardScaleMap.getDeviceDefaultKeyboardScale(forPortrait: self.isPortrait)
 
     return scaling?.bannerHeight ?? 38 // default for iPhone SE, older/smaller devices

diff --git a/ios/engine/KMEI/KeymanEngine/Classes/Keyboard/KeymanWebViewController.swift b/ios/engine/KMEI/KeymanEngine/Classes/Keyboard/KeymanWebViewController.swift
@@ -775,15 +775,17 @@ extension KeymanWebViewController {
    * overwrite that value with a default value derived for this device.
    */
   func writeKeyboardHeightIfDoesNotExist(isPortrait: Bool, height: CGFloat) {
-    let writeMessage = "writeKeyboardHeight, isPortrait: \(isPortrait) height: \(height)"
+    let writeMessage = "writeKeyboardHeightIfDoesNotExist, isPortrait: \(isPortrait) height: \(height)"
     os_log("%{public}s", log:KeymanEngineLogger.ui, type: .info, writeMessage)
     if (isPortrait) {
-      if (Storage.active.userDefaults.object(forKey: Key.portraitKeyboardHeight) != nil) {
+      if (Storage.active.userDefaults.object(forKey: Key.portraitKeyboardHeight) == nil) {
         Storage.active.userDefaults.portraitKeyboardHeight = height
+        os_log("portrait keyboardHeight default value written", log:KeymanEngineLogger.ui, type: .info, writeMessage)
       }
     } else {
-      if (Storage.active.userDefaults.object(forKey: Key.landscapeKeyboardHeight) != nil) {
+      if (Storage.active.userDefaults.object(forKey: Key.landscapeKeyboardHeight) == nil) {
         Storage.active.userDefaults.landscapeKeyboardHeight = height
+        os_log("landscape keyboardHeight default value written", log:KeymanEngineLogger.ui, type: .info, writeMessage)
       }
     }
   }