Merge pull request #12162 from keymanapp/fix/windows/crowdin-hide-str…

…ings fix(windows): "Keyman" is not localized in UI strings
keymanapp · Aug 19, 2024 · cd17ffb · cd17ffb
2 parents 402b196 + de0b2b5
commit cd17ffb
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 4 deletions.
diff --git a/windows/src/desktop/kmshell/xml/splash.xsl b/windows/src/desktop/kmshell/xml/splash.xsl
@@ -30,7 +30,13 @@
   <div id="family"></div>
 
   <a href="keyman:start" id="startNow" class="button">
-    <div class="btn btn-blue"><xsl:value-of select="$locale/string[@name='S_Splash_Start']"/></div>
+    <div class="btn btn-blue">
+      <xsl:variable name="originalText" select="$locale/string[@name='S_Splash_Start_2']"/>
+      <xsl:variable name="replacement" select="'Keyman'"/>
+      <xsl:variable name="beforePlaceholder" select="substring-before($originalText, '%0:s')"/>
+      <xsl:variable name="afterPlaceholder" select="substring-after($originalText, '%0:s')"/>
+      <xsl:value-of select="concat($beforePlaceholder, $replacement, $afterPlaceholder)"/>
+    </div>
   </a>
   <a class="button" id="config" href="keyman:config"><div class="btn btn-orange"><xsl:value-of select="$locale/string[@name='S_Splash_Configuration']"/></div></a>
 

diff --git a/windows/src/desktop/kmshell/xml/strings.xml b/windows/src/desktop/kmshell/xml/strings.xml
@@ -792,13 +792,18 @@ keyboard that you use in Windows.  Keyman keyboards will adapt automatically to
   <!-- Context: Splash Dialog -->
   <!-- String Type: PlainText -->
   <!-- Introduced: 8.0.288.0 -->
-  <string name="S_Splash_Name" comment="Splash major title">Keyman</string>
+  <string name="S_Splash_Name" translatable="false" comment="Splash major title">Keyman</string>
 
   <!-- Context: Splash Dialog -->
   <!-- String Type: PlainText -->
   <!-- Introduced: 8.0.294.0 -->
   <string name="S_Splash_Start" comment="Start Keyman button">Start Keyman</string>
 
+  <!-- Context: Splash Dialog -->
+  <!-- String Type: PlainText -->
+  <!-- Introduced: 18.0 -->
+  <string name="S_Splash_Start_2" comment="Start {Keyman} button">Start %1$s</string>
+
   <!-- Context: Splash Dialog -->
   <!-- String Type: PlainText -->
   <!-- Introduced: 8.0.294.0 -->
@@ -855,7 +860,7 @@ keyboard that you use in Windows.  Keyman keyboards will adapt automatically to
   <!-- Context: Formatted Messages -->
   <!-- String Type: FormatString -->
   <!-- Introduced: 7.0.230.0 -->
-  <string name="SKShortApplicationTitle" comment="Product name">Keyman</string>
+  <string name="SKShortApplicationTitle" translatable="false" comment="Product name">Keyman</string>
 
 
 
@@ -1021,7 +1026,7 @@ keyboard that you use in Windows.  Keyman keyboards will adapt automatically to
   <!-- Context: Formatted Messages -->
   <!-- String Type: FormatString -->
   <!-- Introduced: 7.0.230.0 -->
-  <string name="SKApplicationTitle" comment="Product name used for the title of message boxes and message dialogs">Keyman</string>
+  <string name="SKApplicationTitle" translatable="false" comment="Product name used for the title of message boxes and message dialogs">Keyman</string>
 
   <!-- Parameters: %1$s = Version number string -->
   <!-- Context: Formatted Messages -->