Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug(developer): Web testing server fails to launch #10872

Closed
jahorton opened this issue Feb 28, 2024 · 0 comments · Fixed by #10903
Closed

bug(developer): Web testing server fails to launch #10872

jahorton opened this issue Feb 28, 2024 · 0 comments · Fixed by #10903
Assignees
@mcdurdin
Labels
bug developer/
Milestone
B17S3

Comments

@jahorton
Copy link
Contributor

With the latest beta build - 17.0.277-bet, attempting to "Test Keyboard on Web" from within Developer fails. After a spot of debugging with @mcdurdin, we found the following:

image

This is nigh-certainly related to #10845.
@jahorton jahorton added this to the B17S2 milestone Feb 28, 2024
@mcdurdin mcdurdin self-assigned this Feb 29, 2024
mcdurdin added a commit that referenced this issue Mar 1, 2024
@mcdurdin
fix(developer): move osk.ts from developer-utils to kmc-kmn
9776aa7 
Fixes #10872. Modifies #10845.

developer-utils is also used by server. Because osk.ts depends on
common-types, this introduced a transitive dependency for
developer-utils. Packaging server for deployment as part of Keyman
Developer is fragile and we need to hand-code our internal dependencies,
as npm bundling struggles with in-repo dependencies. So we need to avoid
introducing extra dependencies into developer-utils at this time.

It turns out that osk.ts is used by kmc-kmn and kmc-analyze. kmc-analyze
already has a dependency on kmc-kmn, so it makes sense to put it there.
@mcdurdin mcdurdin mentioned this issue Mar 1, 2024
Merged
@mcdurdin mcdurdin linked a pull request Mar 1, 2024 that will close this issue
fix(developer): move osk.ts from developer-utils to kmc-kmn #10903
Merged
@mcdurdin mcdurdin modified the milestones: B17S2, B17S3 Mar 3, 2024
@mcdurdin mcdurdin closed this as completed Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mcdurdin mcdurdin

Labels
bug developer/
Projects
None yet
Milestone
B17S3
Development

Successfully merging a pull request may close this issue.

fix(developer): move osk.ts from developer-utils to kmc-kmn keymanapp/keyman
2 participants
@mcdurdin @jahorton