fix(developer): move osk.ts from developer-utils to kmc-kmn #10903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #10872. Modifies #10845. developer-utils is also used by server. Because osk.ts depends on common-types, this introduced a transitive dependency for developer-utils. Packaging server for deployment as part of Keyman Developer is fragile and we need to hand-code our internal dependencies, as npm bundling struggles with in-repo dependencies. So we need to avoid introducing extra dependencies into developer-utils at this time. It turns out that osk.ts is used by kmc-kmn and kmc-analyze. kmc-analyze already has a dependency on kmc-kmn, so it makes sense to put it there.
keymanapp-test-bot
bot
added
has-user-test
user-test-required
User Test ResultsTest specification and instructions
Test Artifacts
|
api-extractor returned the following error:
```
ERROR: The "export * as ___" syntax is not supported yet; as a workaround, use "import * as ___" with a separate "export { ___ }" declaration
```
Test Results
|
keymanapp-test-bot
bot
removed
the
user-test-required
|
Changes in this pull request will be available for download in Keyman version 17.0.282-beta |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10872. Modifies #10845.
developer-utils is also used by server. Because osk.ts depends on common-types, this introduced a transitive dependency for server. Packaging server for deployment as part of Keyman Developer is fragile and we need to hand-code our internal dependencies, as npm bundling struggles with in-repo dependencies. So we need to avoid introducing extra dependencies into developer-utils at this time.
It turns out that osk.ts is used by kmc-kmn and kmc-analyze. kmc-analyze already has a dependency on kmc-kmn, so it makes sense to put it there.
User Testing