Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug(developer): Invalid project file when looking for parent project at launch can cause EProjectLoader: Exception EProjectLoader in module tike.exe at 00339939. #11557

Closed
sentry-io bot opened this issue May 27, 2024 · 0 comments · Fixed by #11558 or #11559
Closed

bug(developer): Invalid project file when looking for parent project at launch can cause EProjectLoader: Exception EProjectLoader in module tike.exe at 00339939. #11557

sentry-io bot opened this issue May 27, 2024 · 0 comments · Fixed by #11558 or #11559
Assignees
@mcdurdin
Labels
bug developer/
Milestone
A18S3

Comments

@sentry-io
Copy link

sentry-io bot commented May 27, 2024 •
edited by mcdurdin
Loading

Sentry Issue: KEYMAN-DEVELOPER-1Z2

OS Version: Windows 10.0.19045 (2965)
Report Version: 104


Application Specific Information:
Exception EProjectLoader in module tike.exe at 00339939.
Not a valid project file.


Thread 0
0   tike.exe                        0x739939            Keyman.Developer.System.Project.ProjectFile.TProject.ImportFromIni (Keyman.Developer.System.Project.ProjectFile.pas:1169)
1   tike.exe                        0x738506            Keyman.Developer.System.Project.ProjectFile.TProject.Load (Keyman.Developer.System.Project.ProjectFile.pas:853)
2   tike.exe                        0x7380bd            Keyman.Developer.System.Project.ProjectFile.TProject.Create (Keyman.Developer.System.Project.ProjectFile.pas:782)
3   tike.exe                        0xe8991e            Keyman.Developer.System.ProjectOwningFile.CheckOwnerProjectForFile (Keyman.Developer.System.ProjectOwningFile.pas:74)
4   tike.exe                        0xe89881            Keyman.Developer.System.ProjectOwningFile.FindOwnerProjectForFile (Keyman.Developer.System.ProjectOwningFile.pas:58)
5   tike.exe                        0xe8be58            Keyman.Developer.System.LaunchProjects.TLaunchProjects.GroupFilenamesIntoProjects (Keyman.Developer.System.LaunchProjects.pas:144)
6   tike.exe                        0xe8e793            Keyman.Developer.System.TikeCommandLine.TTikeCommandLine.Process (Keyman.Developer.System.TikeCommandLine.pas:172)
7   tike.exe                        0xe9c9f9            Keyman.Developer.System.Main.RunWithExceptionsHandled (Keyman.Developer.System.Main.pas:61)
8   tike.exe                        0xe9c8f2            Keyman.Developer.System.Main.RunKeymanDeveloper (Keyman.Developer.System.Main.pas:43)
9   tike.exe                        0xeb5388            tike.tike
10  KERNEL32.DLL                    0x76de00c8          BaseThreadInitThunk
11  ntdll.dll                       0x77397b4d          _RtlUserThreadStart
12  ntdll.dll                       0x77397b1d          _RtlUserThreadStart

17.0.325

This arises when a user opens a Keyman source file e.g. from Explorer, and the LaunchProjects module tries to find its owning project, but the file it stumbles on is not a valid .kpj project file.
@mcdurdin mcdurdin self-assigned this May 27, 2024
@mcdurdin mcdurdin added this to the A18S3 milestone May 27, 2024
mcdurdin added a commit that referenced this issue May 27, 2024
@mcdurdin
fix(developer): handle invalid project file when scanning for owner p…
15acd71 
…roject

Also updates the only other place where a project file is loaded like
this, in the project renderer, and handles it too (this scenario is
less likely to happen because the project file must already have been
loaded in order to be presented in the UI).

Fixes: #11557
Fixes: KEYMAN-DEVELOPER-1Z2
@mcdurdin mcdurdin mentioned this issue May 27, 2024
Merged
mcdurdin added a commit that referenced this issue May 27, 2024
@mcdurdin
fix(developer): handle invalid project file when scanning for owner p…
e46a2b2 
…roject

Also updates the only other place where a project file is loaded like
this, in the project renderer, and handles it too (this scenario is
less likely to happen because the project file must already have been
loaded in order to be presented in the UI).

Fixes: #11557
Fixes: KEYMAN-DEVELOPER-1Z2
@mcdurdin mcdurdin mentioned this issue May 27, 2024
Merged
@mcdurdin mcdurdin linked a pull request May 27, 2024 that will close this issue
fix(developer): handle invalid project file when scanning for owner project 🍒 🏠 #11559
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mcdurdin mcdurdin

Labels
bug developer/
Projects
None yet
Milestone
A18S3
1 participant
@mcdurdin