Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(developer): handle invalid project file when scanning for owner project 🍒 🏠 #11559

Conversation

mcdurdin
Copy link
Member

Cherry-pick of #11558.

Also updates the only other place where a project file is loaded like this, in the project renderer, and handles it too (this scenario is less likely to happen because the project file must already have been loaded in order to be presented in the UI).

Fixes: #11557
Fixes: KEYMAN-DEVELOPER-1Z2

@keymanapp-test-bot skip

…roject

Also updates the only other place where a project file is loaded like
this, in the project renderer, and handles it too (this scenario is
less likely to happen because the project file must already have been
loaded in order to be presented in the UI).

Fixes: #11557
Fixes: KEYMAN-DEVELOPER-1Z2
@keymanapp-test-bot
Copy link

User Test Results

Test specification and instructions

User tests are not required

@keymanapp-test-bot keymanapp-test-bot bot changed the title fix(developer): handle invalid project file when scanning for owner project 🍒 fix(developer): handle invalid project file when scanning for owner project 🍒 🏠 May 27, 2024
@keymanapp-test-bot keymanapp-test-bot bot added this to the A18S3 milestone May 27, 2024
Copy link
Contributor

@rc-swag rc-swag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcdurdin mcdurdin merged commit b79943e into stable-17.0 May 30, 2024
5 checks passed
@mcdurdin mcdurdin deleted the fix/developer/cherry-pick/11557-invalid-project-file-at-launch branch May 30, 2024 02:29
@keyman-server
Copy link
Collaborator

Changes in this pull request will be available for download in Keyman version 17.0.326

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick Change already merged into another (stable) branch developer/ide/ developer/ fix stable
Projects
None yet
3 participants