Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(mac): implement loading of keyboard blob in Keyman for Mac #12499

Closed
Tracked by #12497
ermshiperete opened this issue Oct 2, 2024 · 0 comments · Fixed by #12760
Closed
Tracked by #12497

refactor(mac): implement loading of keyboard blob in Keyman for Mac #12499

ermshiperete opened this issue Oct 2, 2024 · 0 comments · Fixed by #12760
Assignees
@sgschantz
Labels
mac/ refactor
Milestone
A18S16

Comments

@ermshiperete
Copy link
Contributor

ermshiperete commented Oct 2, 2024 •
edited
Loading

Once #12459 is merged we can implement loading of the keyboard blob in the engine and call km_core_keyboard_load_from_blob instead of km_core_keyboard_load.
@ermshiperete ermshiperete mentioned this issue Oct 2, 2024
Closed
5 tasks
@ermshiperete ermshiperete changed the title implement loading of blob in Keyman for Mac refactor(mac): implement loading of keyboard blob in Keyman for Mac Oct 2, 2024
@sgschantz sgschantz added this to the A18S24 milestone Nov 4, 2024
@mcdurdin mcdurdin modified the milestones: A18S24, A18S17, A18S16 Nov 25, 2024
@mcdurdin mcdurdin moved this to Todo in Keyman Nov 28, 2024
sgschantz added a commit that referenced this issue Dec 2, 2024
@sgschantz
refactor(mac): pass kmx data blob to keyman core instead of file path
42ba0a4 
Fixes: #12499
@sgschantz sgschantz mentioned this issue Dec 3, 2024
Merged
@github-project-automation github-project-automation bot moved this from Todo to Done in Keyman Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgschantz sgschantz

Labels
mac/ refactor
Projects
Keyman
Archived in project
Milestone
A18S16
Development

Successfully merging a pull request may close this issue.

refactor(mac): pass kmx data blob to keyman core instead of file path keymanapp/keyman
3 participants
@ermshiperete @mcdurdin @sgschantz