Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(common): work around LDML DTD bug when <import> has no base= attribute 🙀 #12749

Open
srl295 opened this issue Nov 29, 2024 · 3 comments
Open

feat(common): work around LDML DTD bug when <import> has no base= attribute 🙀 #12749

srl295 opened this issue Nov 29, 2024 · 3 comments
Assignees
@srl295
Labels
common/ feat
Milestone
A18S18

Comments

@srl295
Copy link
Member

srl295 commented Nov 29, 2024 •
edited by mcdurdin
Loading

see #10649 (comment)

until https://unicode-org.atlassian.net/browse/CLDR-18138 is fixed upstream (which is on me) we could patch the LDML schema to not make base="cldr" implied. For now, authors can do <import base="" path="something.xml" />
@srl295 srl295 self-assigned this Nov 29, 2024
@srl295 srl295 added this to the A18S17 milestone Nov 29, 2024
srl295 added a commit that referenced this issue Nov 29, 2024
@srl295
feat(developer): support local imports
01a47c3 
- added a new reader callback option, localImportsPaths
- due to the CLDR issue #12749 use base=""
- add tests
- some bugfixes in import messages
- add an ImportStatus section to determine if something is a local import

Fixes: #10649
@srl295 srl295 mentioned this issue Nov 29, 2024
Merged
@mcdurdin
Copy link
Member

For now, authors can do <import base="" path="something.xml" />

Anything that is left for authors to workaround will live forever. Let's not go there -- we need to address this before we merge #12750, or certainly before we go to beta.

@srl295
Copy link
Member Author

srl295 commented Nov 30, 2024

Wasn't meaning to leave it hanging around, but wanted to split it into two problems. Sounds good as far as priority.

@srl295
Copy link
Member Author

srl295 commented Nov 30, 2024

Also base="" may need to be supported for compatibility with 45 and 46 DTD/Schema. Or do you think the DTD should forbid base=""?

@darcywong00 darcywong00 modified the milestones: A18S17, A18S18 Dec 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@srl295 srl295

Labels
common/ feat
Projects
Keyman
Status: No status
Milestone
A18S18
Development

No branches or pull requests
3 participants
@srl295 @mcdurdin @darcywong00