Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(developer,core): local imports 🙀 #12750

Merged
merged 9 commits into from
Dec 5, 2024
Merged

feat(developer,core): local imports 🙀 #12750

merged 9 commits into from
Dec 5, 2024

Conversation

srl295
Copy link
Member

@srl295 srl295 commented Nov 29, 2024 •
edited
Loading

Fixes: #10649

Note:

  • I've tested simple paths something.xml which works for the same dir as the source xml
  • also tested more complex paths starting with ./ etc.
  • and, even absolute paths work, though those are not tested in unit tests.

@keymanapp-test-bot skip

@srl295
feat(developer): support local imports
01a47c3 
- added a new reader callback option, localImportsPaths
- due to the CLDR issue #12749 use base=""
- add tests
- some bugfixes in import messages
- add an ImportStatus section to determine if something is a local import

Fixes: #10649
@srl295
feat(developer): support local imports in kmc
e99f6ac 
- basic changes to support local imports

Fixes: #10649
@srl295
feat(developer): test local imports in kmc-ldml
01fed4b 
- also improve callback visibility when XML fails to load

Fixes: #10649
@srl295
feat(core): test local imports in kmc
b1b6587 
Fixes: #10649
@keymanapp-test-bot
Copy link

keymanapp-test-bot bot commented Nov 29, 2024 •
edited
Loading

User Test Results

Test specification and instructions

User tests are not required

Test Artifacts

@keymanapp-test-bot keymanapp-test-bot bot added this to the A18S16 milestone Nov 29, 2024
@srl295 srl295 self-assigned this Nov 29, 2024
@srl295
Copy link
Member Author

srl295 commented Nov 29, 2024

fyi @sovichet !

@srl295 srl295 linked an issue Nov 30, 2024 that may be closed by this pull request
feat(developer): ldml - support local imports #10649
Closed
@mcdurdin mcdurdin mentioned this pull request Nov 30, 2024
Open
@mcdurdin mcdurdin self-assigned this Nov 30, 2024
mcdurdin
mcdurdin approved these changes Nov 30, 2024
View reviewed changes
Copy link
Member

@mcdurdin mcdurdin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, a few comments, all pretty minor

developer/src/common/web/utils/src/common-messages.ts Outdated Show resolved Hide resolved
developer/src/common/web/utils/src/types/ldml-keyboard/ldml-keyboard-xml-reader.ts Outdated Show resolved Hide resolved
developer/src/common/web/utils/src/types/ldml-keyboard/ldml-keyboard-xml-reader.ts Outdated Show resolved Hide resolved
developer/src/common/web/utils/src/types/ldml-keyboard/ldml-keyboard-xml-reader.ts Outdated Show resolved Hide resolved
developer/src/common/web/utils/src/types/ldml-keyboard/ldml-keyboard-xml-reader.ts Show resolved Hide resolved
developer/src/common/web/utils/src/types/ldml-keyboard/ldml-keyboard-xml.ts Outdated Show resolved Hide resolved
developer/src/kmc/src/commands/buildTestData/index.ts Outdated Show resolved Hide resolved
srl295 and others added 3 commits December 2, 2024 11:37
@srl295
Merge branch 'feat/developer/7394-verify-normalization-epic-ldml' int…
75d172a 
…o feat/developer/10649-local-imports
@srl295 @mcdurdin
Apply suggestions from code review
48da8fd 
Co-authored-by: Marc Durdin <[email protected]>
@srl295
feat(developer): local imports directory fixes
f4f0355 
- use path.join instead of path.resolve
- rename importsPath to cldrImportsPath
- remove k_015_importlocal from core, as it duplicated tests in common and developer

Fixes: #10649
@github-actions github-actions bot added core/ Keyman Core and removed core/ Keyman Core labels Dec 2, 2024
@srl295
chore(developer): update per code review
9a338ab 
- support empty string as import base
@github-actions github-actions bot added core/ Keyman Core and removed core/ Keyman Core labels Dec 4, 2024
@github-actions github-actions bot added core/ Keyman Core and removed core/ Keyman Core labels Dec 4, 2024
Base automatically changed from feat/developer/7394-verify-normalization-epic-ldml to master December 4, 2024 22:58
@srl295
Copy link
Member Author

srl295 commented Dec 4, 2024

looks like transient failure, retrying

@srl295 srl295 merged commit 57b5530 into master Dec 5, 2024
6 checks passed
@srl295 srl295 deleted the feat/developer/10649-local-imports branch December 5, 2024 18:15
@keyman-server
Copy link
Collaborator

Changes in this pull request will be available for download in Keyman version 18.0.154-alpha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcdurdin mcdurdin mcdurdin approved these changes

@darcywong00 darcywong00 Awaiting requested review from darcywong00 darcywong00 is a code owner

@SabineSIL SabineSIL Awaiting requested review from SabineSIL SabineSIL is a code owner

@markcsinclair markcsinclair Awaiting requested review from markcsinclair markcsinclair is a code owner

@rc-swag rc-swag Awaiting requested review from rc-swag

Assignees

@srl295 srl295

@mcdurdin mcdurdin

Labels
core/ Keyman Core developer/compilers/ developer/ feat
Projects
Keyman
Archived in project
Milestone
A18S16
Development

Successfully merging this pull request may close these issues.

feat(developer): ldml - support local imports
3 participants
@srl295 @keyman-server @mcdurdin