Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(core): Add test keyboard for text selection tests #10026

Merged
merged 3 commits into from
Nov 24, 2023
Merged

chore(core): Add test keyboard for text selection tests #10026

merged 3 commits into from
Nov 24, 2023

Conversation

ermshiperete
Copy link
Contributor

Part of #9073.

@keymanapp-test-bot skip

@keymanapp-test-bot
Copy link

keymanapp-test-bot bot commented Nov 17, 2023 •
edited
Loading

User Test Results

Test specification and instructions

User tests are not required

Test Artifacts

@keymanapp-test-bot keymanapp-test-bot bot added this to the A17S26 milestone Nov 17, 2023
@github-actions github-actions bot added core/ Keyman Core and removed core/ Keyman Core labels Nov 20, 2023
@github-actions github-actions bot added core/ Keyman Core and removed core/ Keyman Core labels Nov 21, 2023
@ermshiperete ermshiperete force-pushed the chore/testkeyboard branch 2 times, most recently from b7cca17 to e9d7f3d Compare November 21, 2023 10:36
@github-actions github-actions bot added core/ Keyman Core and removed core/ Keyman Core labels Nov 21, 2023
@github-actions github-actions bot added core/ Keyman Core and removed core/ Keyman Core labels Nov 21, 2023
@github-actions github-actions bot added web/ core/ Keyman Core and removed core/ Keyman Core labels Nov 22, 2023
@github-actions github-actions bot added core/ Keyman Core and removed core/ Keyman Core labels Nov 22, 2023
@ermshiperete ermshiperete marked this pull request as ready for review November 23, 2023 09:52
@github-actions github-actions bot added core/ Keyman Core and removed core/ Keyman Core labels Nov 23, 2023
@github-actions github-actions bot added core/ Keyman Core and removed core/ Keyman Core labels Nov 23, 2023
@github-actions github-actions bot added core/ Keyman Core and removed core/ Keyman Core labels Nov 23, 2023
mcdurdin
mcdurdin approved these changes Nov 23, 2023
View reviewed changes
Copy link
Member

@mcdurdin mcdurdin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could remove the unnecessary files, e.g. all the .md files, etc, because they are a bit noisy, but at the same time, they are just boilerplate so they aren't getting in the way.

@ermshiperete ermshiperete merged commit 20c3614 into master Nov 24, 2023
15 checks passed
@ermshiperete ermshiperete deleted the chore/testkeyboard branch November 24, 2023 10:01
@keyman-server
Copy link
Collaborator

Changes in this pull request will be available for download in Keyman version 17.0.217-alpha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcdurdin mcdurdin mcdurdin approved these changes

@jahorton jahorton Awaiting requested review from jahorton jahorton is a code owner

Assignees
No one assigned
Labels
chore common/ core/ Keyman Core web/
Projects
None yet
Milestone
A17S26
Development

Successfully merging this pull request may close these issues.
3 participants
@ermshiperete @keyman-server @mcdurdin