feat(windows): Remove UI com online-update check 📲 💽 #10156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keymanapp-test-bot
bot
added
the
user-test-missing
User Test ResultsTest specification and instructions User tests are not required Test Artifacts |
keymanapp-test-bot
bot
changed the title
rc-swag
changed the base branch from
epic/windows-upgrades
to
epic/windows-updates
keymanapp-test-bot
bot
changed the title
rc-swag
commented
Dec 6, 2023
rc-swag
commented
Dec 6, 2023
rc-swag
commented
Dec 6, 2023
darcywong00
changed the title
Just using the TUpdateCheckResponse gives us enough detail for now as we no longer have a UI set which packages to install
ermshiperete
approved these changes
Dec 11, 2023
windows/src/desktop/kmshell/main/Keyman.System.RemoteUpdateCheck.pas
Outdated
Show resolved
Hide resolved
mcdurdin
requested changes
Dec 12, 2023
windows/src/desktop/kmshell/main/Keyman.System.RemoteUpdateCheck.pas
Outdated
Show resolved
Hide resolved
windows/src/desktop/kmshell/main/Keyman.System.RemoteUpdateCheck.pas
Outdated
Show resolved
Hide resolved
windows/src/desktop/kmshell/main/Keyman.System.RemoteUpdateCheck.pas
Outdated
Show resolved
Hide resolved
windows/src/desktop/kmshell/main/Keyman.System.RemoteUpdateCheck.pas
Outdated
Show resolved
Hide resolved
windows/src/desktop/kmshell/main/Keyman.System.RemoteUpdateCheck.pas
Outdated
Show resolved
Hide resolved
windows/src/desktop/kmshell/main/Keyman.System.RemoteUpdateCheck.pas
Outdated
Show resolved
Hide resolved
windows/src/desktop/kmshell/main/Keyman.System.RemoteUpdateCheck.pas
Outdated
Show resolved
Hide resolved
windows/src/desktop/kmshell/main/Keyman.System.RemoteUpdateCheck.pas
Outdated
Show resolved
Hide resolved
Co-authored-by: Marc Durdin <[email protected]>
mcdurdin
approved these changes
Dec 13, 2023
Comment on lines
184
to
191
| if not DownloadFile(Params.Packages[i].DownloadURL, Params.Packages[i].SavePath) then // I2742 | ||
| begin | ||
| Params.Packages[i].Install := False; // Download failed but install other files | ||
| end | ||
| else | ||
| Inc(downloadCount); | ||
| FDownload.StartPosition := FDownload.StartPosition + Params.Packages[i].DownloadSize; | ||
| end; |
There was a problem hiding this comment.
Suggested change
| if not DownloadFile(Params.Packages[i].DownloadURL, Params.Packages[i].SavePath) then // I2742 | |
| begin | |
| Params.Packages[i].Install := False; // Download failed but install other files | |
| end | |
| else | |
| Inc(downloadCount); | |
| FDownload.StartPosition := FDownload.StartPosition + Params.Packages[i].DownloadSize; | |
| end; | |
| if not DownloadFile(Params.Packages[i].DownloadURL, Params.Packages[i].SavePath) then // I2742 | |
| begin | |
| Params.Packages[i].Install := False; // Download failed but install other files | |
| end | |
| else | |
| Inc(downloadCount); | |
| FDownload.StartPosition := FDownload.StartPosition + Params.Packages[i].DownloadSize; | |
| end; |
| else | ||
| // Keyboard Packages | ||
| FDownload.StartPosition := 0; | ||
| for i := 0 to High(Params.Packages) do | ||
| begin |
keymanapp-test-bot
bot
removed
the
user-test-missing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just first step in #10038
Fixes: #10119
I discovered
- Remove all UI calls from it and use callbacks
Not going to use call backs at all at this stage.
- Keep parsing separate
For now I have this testing with
kmshell.exe -bucI will have this separated more in the next PR- Consider merging TOnlineUpdateCheckParams and TUpdateCheckResponse
This I think can be done I just have a question around
old versionit seems that we don't want to use the old version in the Response. Probably because it is just the "previous" version. Where as the version currently installed could be even older. We could make the Fparams of typeTUpdateCheckResponseas the only other piece of data we would lose is aTRemoteUpdateCheckResultwhich I will not be using.- Figure out how SPackageUpgradeFilename is used for upgrading packages and how it fits into the new check/download, with later install model
This was just flat file for recording the file names of the packages in the temporary data location in the case when the elevated call was required. We now have all the information we need in the
cache.json@keymanapp-test-bot skip