-
-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(linux): Replace deprecated pkg_resources
module with packaging.version
#10860
Conversation
User Test ResultsTest specification and instructions
Test Artifacts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
It isn't enough to have the package as build dependency, we also have to list is in the binary package or in the `install_requires` list in `setup.py`. This change also adds other missing python modules to `install_requires` so that things work correctly if building/installing from source.
a5cb464
to
f899627
Compare
Test ResultsGROUP_FOCAL: Ubuntu 20.04 Focal with Gnome Shell and X11 |
Test ResultsGROUP_NOBLE: Ubuntu 24.04 Noble with Gnome Shell and X11 or Wayland |
…aces Previous commit missed a few places where `pkg_resources` module was used.
GROUP_NOBLE:
|
Changes in this pull request will be available for download in Keyman version 17.0.291-beta |
Fixes #10850.
User Testing
Preparations
The tests should be run on these Linux platforms:
Install build artifacts of this PR
Reboot
Tests
TEST_NO_WARNING:
km-package-install --version