refactor(developer): cleanup kmn compiler message namespaces #10867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is in preparation for message documentation. Moves all messages with the KmnCompiler namespace into KmnCompilerMessages. For now, keeps CompilerMessages class as a subclass of KmnCompilerMessages, for removal in 18.0. Moves messages with KmnCompiler namespace from kmw-compiler-messages.ts to kmn-compiler-messages.ts. This avoids confusion as to source of message, and should allow us in the future to split the classes entirely.
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
darcywong00
reviewed
Feb 28, 2024
darcywong00
reviewed
Feb 28, 2024
srl295
approved these changes
Feb 28, 2024
…or/developer/10207-kmn-compiler-message-namespaces
Base automatically changed from
docs/developer/10207-kmc-kmn-documentation
to
beta
March 1, 2024 00:52
mcdurdin
deleted the
refactor/developer/10207-kmn-compiler-message-namespaces
branch
|
Changes in this pull request will be available for download in Keyman version 17.0.280-beta |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in preparation for message documentation.
Moves all messages with the KmnCompiler namespace into KmnCompilerMessages. For now, keeps CompilerMessages class as a subclass of KmnCompilerMessages, for removal in 18.0.
Moves messages with KmnCompiler namespace from kmw-compiler-messages.ts to kmn-compiler-messages.ts. This avoids confusion as to source of message, and should allow us in the future to split the classes entirely.
@keymanapp-test-bot skip