-
-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ios): cross-paragraph keyboard rules #10905
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keymanapp-test-bot
bot
added
has-user-test
user-test-required
User tests have not been completed
labels
Mar 1, 2024
User Test ResultsTest specification and instructions
Test Artifacts
|
mcdurdin
approved these changes
Mar 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this change makes sense for robustness, even if we want to go further in the future.
LGTM
Test Results
|
keymanapp-test-bot
bot
removed
the
user-test-required
User tests have not been completed
label
Mar 1, 2024
Changes in this pull request will be available for download in Keyman version 17.0.281-beta |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10761.
Turns out my concerns in that issue were well-founded; rules crossing a context-window boundary were not being properly applied. Fortunately, it only takes a couple of small tweaks to fix that... as well as can be done under iOS constraints given 17.0.
Limitations:
To "do better" would require us to track our own version of a context window manually on the iOS side that slides, rather than "jumping" upon a new paragraph start. This is only an idea at this stage, though; it's also certainly too big a project to tackle during the beta cycle.
Given these limitations, I'm not opposed to rejecting this PR at this time due to what is essentially an incomplete solution - those caveats may matter greatly for some scripts and/or languages.
User Testing
TEST_CROSS_PARAGRAPH_RULES: Use the provided specialized test keyboard to verify that the last a-z character is properly rotated by the "rota" key.
Specialized test keyboard: https://jahorton.github.io/last_alphanumeric_rotater.kmp
Source: last_alphanumeric_rotater.zip
common/test/keyboards
? (For desktop use, the 'rota' key isK_BKSLASH
.)a
should rotate tob
, thenc
, etc until reachingz
. Afterz
, it will return toa
.