chore(resources,common,developer,core): ldml update out of techpreview 🙀 #10913

srl295 · 2024-03-01T17:38:32Z

includes patch for bn.xml
pre-release ldml
update to cldr 40fa7fd5b074a203581d04ca0c0b004ab9aa491b (main)

Fixes: #10900
Fixes: #10901

(Review note: split into 4 commits by functional area)

@keymanapp-test-bot skip

keymanapp-test-bot · 2024-03-01T17:38:36Z

User Test Results

Test specification and instructions

User tests are not required

Test Artifacts

Android
Developer
iOS
- Keyman for iOS (simulator image)
- FirstVoices Keyboards for iOS (simulator image)
- TestFlight internal PR build version - 17.0.282 (0.10913.10509)
Keyboards
- Test Keyboards
Linux
macOS
- Keyman for macOS
Web
- KeymanWeb Test Home
Windows

srl295 · 2024-03-03T04:38:02Z

common/web/types/build.sh

+    "$KEYMAN_ROOT/resources/standards-data/ldml-keyboards/45/ldml-keyboard3.schema.json"
+    "$KEYMAN_ROOT/resources/standards-data/ldml-keyboards/45/ldml-keyboardtest3.schema.json"


100% kicking the 'what about 46' can down the road here

- update to cldr 40fa7fd5b074a203581d04ca0c0b004ab9aa491b (main) - alpha1+ - includes patch for bn Fixes: #10900

- updates to support techpreview -> 45 Fixes: #10900

- updates to support techpreview -> 45 - test changes Fixes: #10900

mcdurdin · 2024-03-03T23:22:27Z

9 failing tests:

12:50:29     125 passing (950ms)
12:50:29     1 pending
12:50:29     9 failing
12:50:29   
12:50:29     1) disp
12:50:28          should fail to compile: sections/disp/invalid-var.xml:
12:50:28   
12:50:28         expected errors to be included
12:50:28         + expected - actual
12:50:28   
12:50:28          [
12:50:28            {
12:50:28         -    "code": 3149825
12:50:28         +    "code": 3145756
12:50:28              "detail": [undefined]
12:50:28         -    "message": "Error validating LDML XML file: /keyboard3: required: must have required property 'conformsTo' missingProperty=\"conformsTo\""
12:50:28         +    "message": "Reference to undefined string variable: ${missingdisplay}"
12:50:28            }
12:50:28         +  {
12:50:28         +    "code": 3145756
12:50:28         +    "detail": [undefined]
12:50:28         +    "message": "Reference to undefined string variable: ${missingoutput}"
12:50:28         +  }
12:50:28          ]
12:50:28   
12:50:28         at Context.<anonymous> (file:///C:/BuildAgent/work/7ac43416c45637e9/keyman/developer/src/kmc-ldml/test/helpers/index.ts:250:16)
12:50:28   
12:50:28     2) keys.kmap
12:50:28          should fail to compile: sections/keys/invalid-undefined-var-1.xml:
12:50:28   
12:50:28         expected errors to be included
12:50:28         + expected - actual
12:50:28   
12:50:28          [
12:50:28            {
12:50:28         -    "code": 3149825
12:50:28         +    "code": 3145756
12:50:28              "detail": [undefined]
12:50:28         -    "message": "Error validating LDML XML file: /keyboard3: required: must have required property 'conformsTo' missingProperty=\"conformsTo\""
12:50:28         +    "message": "Reference to undefined string variable: ${varsok}"
12:50:28            }
12:50:28          ]
12:50:28   
12:50:28         at Context.<anonymous> (file:///C:/BuildAgent/work/7ac43416c45637e9/keyman/developer/src/kmc-ldml/test/helpers/index.ts:250:16)
12:50:28   
12:50:28     3) keys.kmap
12:50:28          should fail to compile: sections/keys/invalid-undefined-var-1b.xml:
12:50:28   
12:50:28         expected errors to be included
12:50:28         + expected - actual
12:50:28   
12:50:28          [
12:50:28            {
12:50:28         -    "code": 3149825
12:50:28         +    "code": 3145756
12:50:28              "detail": [undefined]
12:50:28         -    "message": "Error validating LDML XML file: /keyboard3: required: must have required property 'conformsTo' missingProperty=\"conformsTo\""
12:50:28         +    "message": "Reference to undefined string variable: ${varsok}"
12:50:28            }
12:50:28          ]
12:50:28   
12:50:28         at Context.<anonymous> (file:///C:/BuildAgent/work/7ac43416c45637e9/keyman/developer/src/kmc-ldml/test/helpers/index.ts:250:16)
12:50:28   
12:50:28     4) tran
12:50:28          should fail to compile: sections/tran/fail-missing-var-1.xml:
12:50:28   
12:50:28         expected errors to be included
12:50:28         + expected - actual
12:50:28   
12:50:28          [
12:50:28            {
12:50:28         -    "code": 3149825
12:50:28         +    "code": 3145756
12:50:28              "detail": [undefined]
12:50:28         -    "message": "Error validating LDML XML file: /keyboard3: required: must have required property 'conformsTo' missingProperty=\"conformsTo\""
12:50:28         +    "message": "Reference to undefined string variable: ${missingfrom}"
12:50:28            }
12:50:28          ]
12:50:28   
12:50:28         at Context.<anonymous> (file:///C:/BuildAgent/work/7ac43416c45637e9/keyman/developer/src/kmc-ldml/test/helpers/index.ts:250:16)
12:50:28   
12:50:28     5) tran
12:50:28          should fail to compile: sections/tran/fail-missing-var-2.xml:
12:50:28   
12:50:28         expected errors to be included
12:50:28         + expected - actual
12:50:28   
12:50:28          [
12:50:28            {
12:50:28         -    "code": 3149825
12:50:28         +    "code": 3145756
12:50:28              "detail": [undefined]
12:50:28         -    "message": "Error validating LDML XML file: /keyboard3: required: must have required property 'conformsTo' missingProperty=\"conformsTo\""
12:50:28         +    "message": "Reference to undefined string variable: ${missingto}"
12:50:28            }
12:50:28          ]
12:50:28   
12:50:28         at Context.<anonymous> (file:///C:/BuildAgent/work/7ac43416c45637e9/keyman/developer/src/kmc-ldml/test/helpers/index.ts:250:16)
12:50:28   
12:50:28     6) tran
12:50:28          should fail to compile: sections/tran/fail-missing-var-3.xml:
12:50:28   
12:50:28         expected errors to be included
12:50:28         + expected - actual
12:50:28   
12:50:28          [
12:50:28            {
12:50:28         -    "code": 3149825
12:50:28         +    "code": 3145757
12:50:28              "detail": [undefined]
12:50:28         -    "message": "Error validating LDML XML file: /keyboard3: required: must have required property 'conformsTo' missingProperty=\"conformsTo\""
12:50:28         +    "message": "Reference to undefined set variable: $[missingset]"
12:50:28            }
12:50:28          ]
12:50:28   
12:50:28         at Context.<anonymous> (file:///C:/BuildAgent/work/7ac43416c45637e9/keyman/developer/src/kmc-ldml/test/helpers/index.ts:250:16)
12:50:28   
12:50:28     7) tran
12:50:28          should fail to compile: sections/tran/fail-missing-var-4.xml:
12:50:28   
12:50:28         expected errors to be included
12:50:28         + expected - actual
12:50:28   
12:50:28          [
12:50:28            {
12:50:28         -    "code": 3149825
12:50:28         +    "code": 3145757
12:50:28              "detail": [undefined]
12:50:28         -    "message": "Error validating LDML XML file: /keyboard3: required: must have required property 'conformsTo' missingProperty=\"conformsTo\""
12:50:28         +    "message": "Reference to undefined set variable: $[missingset]"
12:50:28            }
12:50:28          ]
12:50:28   
12:50:28         at Context.<anonymous> (file:///C:/BuildAgent/work/7ac43416c45637e9/keyman/developer/src/kmc-ldml/test/helpers/index.ts:250:16)
12:50:28   
12:50:28     8) tran
12:50:28          should fail to compile: sections/tran/fail-missing-var-5.xml:
12:50:28   
12:50:28         expected errors to be included
12:50:28         + expected - actual
12:50:28   
12:50:28          [
12:50:28            {
12:50:28         -    "code": 3149825
12:50:28         +    "code": 3145757
12:50:28              "detail": [undefined]
12:50:28         -    "message": "Error validating LDML XML file: /keyboard3: required: must have required property 'conformsTo' missingProperty=\"conformsTo\""
12:50:28         +    "message": "Reference to undefined set variable: $[missingset]"
12:50:28            }
12:50:28          ]
12:50:28   
12:50:28         at Context.<anonymous> (file:///C:/BuildAgent/work/7ac43416c45637e9/keyman/developer/src/kmc-ldml/test/helpers/index.ts:250:16)
12:50:28   
12:50:28     9) tran
12:50:28          should fail to compile: sections/tran/fail-missing-var-6.xml:
12:50:28   
12:50:28         expected errors to be included
12:50:28         + expected - actual
12:50:28   
12:50:28          [
12:50:28            {
12:50:28         -    "code": 3149825
12:50:28         +    "code": 3145756
12:50:28              "detail": [undefined]
12:50:28         -    "message": "Error validating LDML XML file: /keyboard3: required: must have required property 'conformsTo' missingProperty=\"conformsTo\""
12:50:28         +    "message": "Reference to undefined string variable: ${missingstr}"
12:50:28            }
12:50:28          ]
12:50:28   
12:50:28         at Context.<anonymous> (file:///C:/BuildAgent/work/7ac43416c45637e9/keyman/developer/src/kmc-ldml/test/helpers/index.ts:250:16)
12:50:28   
12:50:28

mcdurdin

Apart from the failing tests, a small update to kmconvert should also address #10901.

developer/src/kmconvert/Keyman.Developer.System.LdmlKeyboardProjectTemplate.pas

…ojectTemplate.pas Co-authored-by: Marc Durdin <[email protected]>

- further fixes

…ymanapp/keyman into chore/resources/10900-ldml-45

- add missing conformsTo

srl295 · 2024-03-04T14:26:50Z

hrm, i think on the third try of generating this i ran kmc/build.sh and missed kmc-ldml/build.sh.. tests are doing their job!

keyman-server · 2024-03-06T18:04:59Z

Changes in this pull request will be available for download in Keyman version 17.0.283-beta

srl295 requested review from mcdurdin, jahorton, darcywong00 and rc-swag as code owners March 1, 2024 17:38

keymanapp-test-bot bot added this to the B17S2 milestone Mar 1, 2024

github-actions bot added developer/ common/ developer/compilers/ common/resources/ Build infrastructure core/ Keyman Core common/web/ chore labels Mar 1, 2024

srl295 self-assigned this Mar 1, 2024

srl295 marked this pull request as draft March 1, 2024 17:44

srl295 force-pushed the chore/resources/10900-ldml-45 branch from 0c9ef49 to f21e675 Compare March 3, 2024 04:37

srl295 marked this pull request as ready for review March 3, 2024 04:37

srl295 commented Mar 3, 2024

View reviewed changes

srl295 added 4 commits March 2, 2024 22:40

chore(resources): ldml update out of techpreview 🙀

a0a5728

- update to cldr 40fa7fd5b074a203581d04ca0c0b004ab9aa491b (main) - alpha1+ - includes patch for bn Fixes: #10900

chore(common): ldml update out of techpreview 🙀

8975a38

- updates to support techpreview -> 45 Fixes: #10900

chore(developer): ldml update out of techpreview 🙀

0ada31b

- updates to support techpreview -> 45 Fixes: #10900

chore(core): ldml update out of techpreview 🙀

17a653f

- updates to support techpreview -> 45 - test changes Fixes: #10900

srl295 force-pushed the chore/resources/10900-ldml-45 branch from f21e675 to 17a653f Compare March 3, 2024 04:40

mcdurdin modified the milestones: B17S2, B17S3 Mar 3, 2024

mcdurdin requested changes Mar 3, 2024

View reviewed changes

developer/src/kmconvert/Keyman.Developer.System.LdmlKeyboardProjectTemplate.pas Outdated Show resolved Hide resolved

This was linked to issues Mar 3, 2024

chore(resources,developer): ldml out of techpreview #10900

Closed

chore(developer): update ldml keyboard template to generate conformsTo=45 #10901

Closed

Update developer/src/kmconvert/Keyman.Developer.System.LdmlKeyboardPr…

1f2be1c

…ojectTemplate.pas Co-authored-by: Marc Durdin <[email protected]>

srl295 added 4 commits March 4, 2024 08:21

chore(core,developer,resources): ldml update out of techpreview 🙀

6d2ae22

- further fixes

Merge branch 'chore/resources/10900-ldml-45' of https://github.com/ke…

582cec8

…ymanapp/keyman into chore/resources/10900-ldml-45

chore(developer): ldml update out of techpreview 🙀

350276b

- add missing conformsTo

Merge branch 'beta' into chore/resources/10900-ldml-45

8c86aff

srl295 requested a review from mcdurdin March 4, 2024 15:52

Merge branch 'beta' into chore/resources/10900-ldml-45

d833a1a

mcdurdin approved these changes Mar 5, 2024

View reviewed changes

srl295 merged commit dfbdfff into beta Mar 6, 2024
25 checks passed

srl295 deleted the chore/resources/10900-ldml-45 branch March 6, 2024 01:26

srl295 mentioned this pull request Mar 25, 2024

fix(core): correct typo in LDML test DTD reference #11068

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(resources,common,developer,core): ldml update out of techpreview 🙀 #10913

chore(resources,common,developer,core): ldml update out of techpreview 🙀 #10913

srl295 commented Mar 1, 2024 •

edited by mcdurdin

Loading

keymanapp-test-bot bot commented Mar 1, 2024 •

edited

Loading

srl295 Mar 3, 2024

mcdurdin commented Mar 3, 2024

mcdurdin left a comment

srl295 commented Mar 4, 2024 •

edited

Loading

keyman-server commented Mar 6, 2024

		"$KEYMAN_ROOT/resources/standards-data/ldml-keyboards/45/ldml-keyboard3.schema.json"
		"$KEYMAN_ROOT/resources/standards-data/ldml-keyboards/45/ldml-keyboardtest3.schema.json"

chore(resources,common,developer,core): ldml update out of techpreview 🙀 #10913

chore(resources,common,developer,core): ldml update out of techpreview 🙀 #10913

Conversation

srl295 commented Mar 1, 2024 • edited by mcdurdin Loading

keymanapp-test-bot bot commented Mar 1, 2024 • edited Loading

User Test Results

Test Artifacts

srl295 Mar 3, 2024

Choose a reason for hiding this comment

mcdurdin commented Mar 3, 2024

mcdurdin left a comment

Choose a reason for hiding this comment

srl295 commented Mar 4, 2024 • edited Loading

keyman-server commented Mar 6, 2024

srl295 commented Mar 1, 2024 •

edited by mcdurdin

Loading

keymanapp-test-bot bot commented Mar 1, 2024 •

edited

Loading

srl295 commented Mar 4, 2024 •

edited

Loading