-
-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(developer): consolidate external links in Developer messages #10918
Conversation
Establishes keyman-urls.ts as a single place for any links to external websites. I searched all .ts files in Keyman Developer source and replaced references to websites with function calls here. Note that the names of individual functions within this class can be easily changed as needed, as the hard part was the consolidation.
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
static readonly FILE_TYPE = (ext: string) => `${KeymanUrls.HELP_KEYMAN_COM}/developer/current-version/reference/file-types/${ext}`; | ||
static readonly KMN_REF = (topic: string) => `${KeymanUrls.HELP_KEYMAN_COM}/developer/language/reference/${topic}`; | ||
static readonly HELP_KEYBOARD = (id: string) => `${KeymanUrls.HELP_KEYMAN_COM}/keyboard/${id}`; | ||
static readonly HELP_MODEL = (id: string) => `${KeymanUrls.HELP_KEYMAN_COM}/model/${id}`; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is /model a TODO?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand the question?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought help documentation for models aren't on help.keyman.com yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gotcha. The link was already there in .model_info files, so this doesn't change anything from Developer side. The TODO remains somewhere, doesn't need to be tracked here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Changes in this pull request will be available for download in Keyman version 17.0.282-beta |
Establishes keyman-urls.ts as a single place for any links to external websites.
I searched all .ts files in Keyman Developer source and replaced references to websites with function calls here. Note that the names of individual functions within this class can be easily changed as needed, as the hard part was the consolidation.
@keymanapp-test-bot skip