Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): make debug list management more robust #10920

Closed
wants to merge 1 commit into from

Conversation

mcdurdin
Copy link
Member

@mcdurdin mcdurdin commented Mar 4, 2024

Relates to #10915.

Note: I am not sure that this is the most appropriate way to ensure that the list is always terminated. Recording here for post-beta patch.

@keymanapp-test-bot keymanapp-test-bot bot added the user-test-missing User tests have not yet been defined for the PR label Mar 4, 2024
@keymanapp-test-bot
Copy link

keymanapp-test-bot bot commented Mar 4, 2024

User Test Results

Test specification and instructions

ERROR: user tests have not yet been defined

Test Artifacts

  • Developer
    • Keyman Developer - build failure
    • Compiler Regression Tests - build failure
    • kmcomp.zip - build failure
  • Keyboards
    • Test Keyboards - build failure
  • Web
  • Windows
    • Keyman for Windows - build failure
    • FirstVoices Keyboards for Windows - build failure
    • Text Editor (32 bit) - build failure
    • Text Editor (64 bit) - build failure

@keymanapp-test-bot keymanapp-test-bot bot added this to the B17S3 milestone Mar 4, 2024
@github-actions github-actions bot added core/ Keyman Core fix labels Mar 4, 2024
@mcdurdin
Copy link
Member Author

mcdurdin commented Mar 7, 2024

Turned this into #10962, closing this for a proper fix later.

@mcdurdin mcdurdin closed this Mar 7, 2024
@mcdurdin mcdurdin deleted the fix/developer/10915-debug-list-robustness branch March 7, 2024 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core/ Keyman Core fix user-test-missing User tests have not yet been defined for the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant