fix(ios): changed build script prepRelease to fix sample builds 🏠 #10940
Conversation
…d by build script
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
keymanapp-test-bot
bot
changed the title
There was a problem hiding this comment.
LGTM, am assuming it works -- hard for me to try it from here at present. The changes I am requesting are nits only but trying to be consistent about quoting. (We could start using shell script linting like @ermshiperete does for the linux scripts
|
@mcdurdin Thanks for the review comments. I still had this PR in draft because it was not quite working. The sample projects could find all their frameworks, but local sample project builds were still failing because they could not find the swiftlint.yml file, the path for which pointed outside of the zip file. I removed the config option from the command to run swiftlint contained in the Xcode script, and it now runs without errors, though I also had to fix a violation that swiftlint found. |
|
Changes in this pull request will be available for download in Keyman version 16.0.146 |
Changed the script responsible for creating the ios sample app zip file so that the sample apps will find their frameworks and build successfully.
fixes #10844
@keymanapp-test-bot skip