-
-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(common): Update standards data #11003
Conversation
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
We just have to be a little careful with testing in case metadata formats have changed. |
One thing that changed is in Other than that it's only updated data AFAICT. |
1a10160
to
03cfc3f
Compare
03cfc3f
to
ce86541
Compare
ce86541
to
d05f564
Compare
Here are some observations using the Delphi debugger. However, I really don't understand the whole code.
For the failing test of
|
The duplicate insertion area was the key here, due to duplicates in the langtag.json source, this meant the dictionary was not completely loaded resulting in these other tests failing. In other words those failed tests where a side effect of the duplicate data error. |
Failing tests due to data issues in langtags.json, reported at:
Note that most of the failing tests are caused by a cascade of errors rather than these root causes. |
ba20fbe
to
15a924e
Compare
@@ -93906,7 +94074,7 @@ | |||
"full": "pht-Thai-TH", | |||
"iana": [ "Phu Thai" ], | |||
"iso639_3": "pht", | |||
"latnnames": [ "Phu Thai or Phuu Thai", "Phu Thai or Phuu Thai" ], | |||
"latnnames": [ "Phu Thai", "Phuu Thai" ], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"latnnames": [ "Phu Thai", "Phuu Thai" ], | |
"latnnames": [ "Phu Thai or Phuu Thai", "Phu Thai or Phuu Thai" ], |
Per discussion in silnrsi/langtags#17 (comment), this is valid.
15a924e
to
46675cd
Compare
46675cd
to
c4dcd38
Compare
Updated to the latest standards data which has the data fixed that previously required to handcraft |
`langtags.json` is directly downloaded from master branch at the GitHub repo silnrsi/langtags@68cf829 because the version served at ldml.api.sil.org still has a duplicate.
c4dcd38
to
4e27f64
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Changes in this pull request will be available for download in Keyman version 18.0.42-alpha |
@keymanapp-test-bot skip