Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(developer): use keyboard3 tag rather than DTD to identify LDML keyboard xml files #11214

Merged
merged 1 commit into from
Apr 12, 2024

Conversation

mcdurdin
Copy link
Member

@mcdurdin mcdurdin commented Apr 11, 2024

Relates to #10469. Apply same test in kmc that we are using in TIKE. Missed this in #10473.

@keymanapp-test-bot skip

…keyboard xml files

Relates to #10469. Apply same test in kmc that we are using in TIKE.
@mcdurdin mcdurdin requested a review from jahorton as a code owner April 11, 2024 21:42
@keymanapp-test-bot
Copy link

User Test Results

Test specification and instructions

User tests are not required

Copy link
Contributor

@darcywong00 darcywong00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@darcywong00 darcywong00 modified the milestones: B17S5, B17S6 Apr 12, 2024
@mcdurdin mcdurdin merged commit 29420f7 into beta Apr 12, 2024
20 checks passed
@mcdurdin mcdurdin deleted the chore/developer/recognize-keyboard3-xml branch April 12, 2024 22:22
@keyman-server
Copy link
Collaborator

Changes in this pull request will be available for download in Keyman version 17.0.308-beta

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants