fix(web): fixes up-flick shortcut issue for longpress when keys support downflicks

[jahorton]

I happened to notice this one yesterday while using sil_euro_latin - our up-flick shortcut for quick longpresses wasn't working.

Rather than make things convoluted with special-case handling this close to release, I figured the simplest way forward is to simply parameterize longpresses and flicks in a way that allows the longpress-flick to win when a key supports both. The old parameterization locked in the start of a full-fledged flick gesture before the longpress up-flick shortcut had a chance to trigger.

User Testing

TEST_LONGPRESSES_AND_FLICKS: Using the sil_euro_latin keyboard, verify the following:

• A simple longpress on a key.
• Holding a key, then moving upward quickly causes the subkey menu to display early.
• Holding a key, then moving downward quickly triggers the key's flick.

[keymanapp-test-bot]

User Test Results

Test specification and instructions

• ✅ TEST_LONGPRESSES_AND_FLICKS (PASSED): 1. Verified that a long press on a key displays the subkey menu on the keyboard. 2. Verified that holding a key and quickly moving it upward causes the subkey menu to display early. 3. Verified that holding a key and quickly moving it downward causes the key's flick.

[jahorton]

For reference, flick-start is specified at priority 3.

keyman/web/src/engine/osk/src/input/gestures/specsForLayout.ts

Lines 731 to 734 in b4ed832

	export function flickStartModel(params: GestureParams): GestureModel<any> {
	return {
	id: 'flick-start',
	resolutionPriority: 3,

[jahorton]

I opted to increase the minimum distance for a flick start due to #10647 - if the existing threshold for quick longpress triggers is already too permissive, reducing it would only make things worse. Thus, increasing the flick-start threshold to match is the safer way forward.

Additionally, #10647 probably indicates that the flick-start threshold needed to increase anyway - if 25% of key height is too permissive for one gesture, it likely is too permissive (as a minimum) for all of them.

[ermshiperete]

Looks like a nice and easy fix 😄

[bharanidharanj]

Test Results

• TEST_LONGPRESSES_AND_FLICKS (PASSED): 1. Verified that a long press on a key displays the subkey menu on the keyboard. 2. Verified that holding a key and quickly moving it upward causes the subkey menu to display early. 3. Verified that holding a key and quickly moving it downward causes the key's flick.

[keyman-server]

Changes in this pull request will be available for download in Keyman version 17.0.307-beta

[mcdurdin]

LGTM