Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change(web): drops need for closures to optimize layout-reflow 🪠 #11238

Merged
merged 1 commit into from
Apr 17, 2024

Conversation

jahorton
Copy link
Contributor

@jahorton jahorton commented Apr 17, 2024

Addresses post-merge review comments from recent optimization PRs - in particular, for #11177.

User Testing

TEST_LIGHT_GESTURES: Do some light testing of a few gesture-enabled keyboards and make sure things work as well as they did before. Nothing too rigorous - we'll handle that with regression & platform-acceptance testing.

@jahorton jahorton requested a review from ermshiperete as a code owner April 17, 2024 06:09
@github-actions github-actions bot added the web/ label Apr 17, 2024
@keymanapp-test-bot keymanapp-test-bot bot added has-user-test user-test-required User tests have not been completed labels Apr 17, 2024
@keymanapp-test-bot
Copy link

keymanapp-test-bot bot commented Apr 17, 2024

User Test Results

Test specification and instructions

  • TEST_LIGHT_GESTURES (PASSED): Tested using the KeymanWeb (Test Unminified KeymanWeb) page on an iPhone 13 Mobile (iOS 17.4) device and here is my observation: 1. Conducted testing on gesture-related features with the Classic 10-key and Diacritic 10-key Rota keyboards, as well as Gesture Prototyping tests, all of which performed as expected. 2. Installed Keyman 17.0.309-beta-test-11238 on the iPhone Mobile and launched the application. 3. Installed the diacritic_rota keyboard. 4. Tested the App_10_Key_Diacritics keyboard and confirmed that it functions correctly.

@keymanapp-test-bot keymanapp-test-bot bot added this to the B17S6 milestone Apr 17, 2024
Copy link
Member

@mcdurdin mcdurdin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you thank you! This is so much clearer without the extra closures and the comments really help for future maintainers. LVGTM

Base automatically changed from chore/web/simple-layout-reflow-polish to beta April 17, 2024 08:36
@bharanidharanj
Copy link

Test Results

  • TEST_LIGHT_GESTURES (PASSED): Tested using the KeymanWeb (Test Unminified KeymanWeb) page on an iPhone 13 Mobile (iOS 17.4) device and here is my observation: 1. Conducted testing on gesture-related features with the Classic 10-key and Diacritic 10-key Rota keyboards, as well as Gesture Prototyping tests, all of which performed as expected. 2. Installed Keyman 17.0.309-beta-test-11238 on the iPhone Mobile and launched the application. 3. Installed the diacritic_rota keyboard. 4. Tested the App_10_Key_Diacritics keyboard and confirmed that it functions correctly.

@keymanapp-test-bot keymanapp-test-bot bot removed the user-test-required User tests have not been completed label Apr 17, 2024
@jahorton jahorton merged commit 5a451dd into beta Apr 17, 2024
16 checks passed
@jahorton jahorton deleted the change/web/layout-without-closures branch April 17, 2024 15:25
@keyman-server
Copy link
Collaborator

Changes in this pull request will be available for download in Keyman version 17.0.309-beta

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants