-
-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(developer): support export of visual keyboard when Keyman for Windows not installed #11244
Merged
mcdurdin
merged 5 commits into
beta
from
fix/developer/11199-export-osk-without-keyman-installed
Apr 26, 2024
Merged
fix(developer): support export of visual keyboard when Keyman for Windows not installed #11244
mcdurdin
merged 5 commits into
beta
from
fix/developer/11199-export-osk-without-keyman-installed
Apr 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dows not installed Fixes #11199.
keymanapp-test-bot
bot
added
has-user-test
user-test-required
User tests have not been completed
labels
Apr 18, 2024
User Test ResultsTest specification and instructions
Test Artifacts |
8 tasks
darcywong00
approved these changes
Apr 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
keymanapp-test-bot
bot
removed
the
user-test-required
User tests have not been completed
label
Apr 25, 2024
The DTD reference at tavultesoft.com is no longer valid. In order for the .xml file to be parseable, we need to remove the DTD reference. This resolves the issue where the emitted .html file is blank, and adds an additional step of verifying that the .xml file loads successfully in the XML to HTML transform.
Good catch -- this was not expected! Now resolved with the latest commit. |
mcdurdin
deleted the
fix/developer/11199-export-osk-without-keyman-installed
branch
April 26, 2024 07:08
Changes in this pull request will be available for download in Keyman version 17.0.315-beta |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11199.
User Testing