Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(developer): support export of visual keyboard when Keyman for Windows not installed #11244

Merged

Conversation

mcdurdin
Copy link
Member

Fixes #11199.

User Testing

  • TEST_EXPORT: Verify that OSK export works on a clean install of Developer.
    1. On a VM, ensure that Keyman for Windows is not installed, and verify that C:\Program Files (x86)\Common Files\Keyman\Keyman Engine does not exist or is empty.
    2. Install Keyman Developer, open a keyboard project with an On Screen Keyboard
    3. In the Keyboard editor, On Screen Keyboard tab, click Export, select 'Images and CSS in subdirectory', and export to a file.
    4. Verify that the export does not crash, and that the output HTML file renders as the exported OSK in a web browser.

@keymanapp-test-bot keymanapp-test-bot bot added has-user-test user-test-required User tests have not been completed labels Apr 18, 2024
@keymanapp-test-bot
Copy link

keymanapp-test-bot bot commented Apr 18, 2024

User Test Results

Test specification and instructions

  • TEST_EXPORT (PASSED): Tested with the attached PR build (Keyman Developer 17.0.310-beta-test-11244) on Windows 11 OS (VM) and here is my observation: 1. Verified that there is no Keyman Engine folder exists in the mentioned path. 2. Installed Keyman Dveloper, Opened an existing keyboard project with an On Screen Keyboard. 3. In the Keyboard editor, OSK tab, Clicked the Export button. Selected 'Images and CSS in subdirectory' and exported to a file. 4. Verified that the export did not crash. 5. Opened the HTML file in a web browser and noticed that it does not show any of the exported OSK on the browser (?). Is this an expected one? (notes)

Test Artifacts

Copy link
Contributor

@darcywong00 darcywong00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bharanidharanj
Copy link

Test Results

  • TEST_EXPORT (PASSED): Tested with the attached PR build (Keyman Developer 17.0.310-beta-test-11244) on Windows 11 OS (VM) and here is my observation: 1. Verified that there is no Keyman Engine folder exists in the mentioned path. 2. Installed Keyman Dveloper, Opened an existing keyboard project with an On Screen Keyboard. 3. In the Keyboard editor, OSK tab, Clicked the Export button. Selected 'Images and CSS in subdirectory' and exported to a file. 4. Verified that the export did not crash. 5. Opened the HTML file in a web browser and noticed that it does not show any of the exported OSK on the browser (?). Is this an expected one?

..no keyman engine in the given path

..exporting file

..opened the html file in a web browser

@keymanapp-test-bot keymanapp-test-bot bot removed the user-test-required User tests have not been completed label Apr 25, 2024
The DTD reference at tavultesoft.com is no longer valid. In order for
the .xml file to be parseable, we need to remove the DTD reference. This
resolves the issue where the emitted .html file is blank, and adds an
additional step of verifying that the .xml file loads successfully in
the XML to HTML transform.
@mcdurdin
Copy link
Member Author

    1. Opened the HTML file in a web browser and noticed that it does not show any of the exported OSK on the browser (?). Is this an expected one?

Good catch -- this was not expected! Now resolved with the latest commit.

@mcdurdin mcdurdin merged commit d019707 into beta Apr 26, 2024
8 checks passed
@mcdurdin mcdurdin deleted the fix/developer/11199-export-osk-without-keyman-installed branch April 26, 2024 07:08
@keyman-server
Copy link
Collaborator

Changes in this pull request will be available for download in Keyman version 17.0.315-beta

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants