Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(developer): prevent xmlns for LDML keyboard template child elements #11251

Merged
merged 1 commit into from
Apr 22, 2024

Conversation

mcdurdin
Copy link
Member

Fixes #11228.

User Testing

@mcdurdin mcdurdin requested a review from darcywong00 as a code owner April 18, 2024 06:50
@keymanapp-test-bot keymanapp-test-bot bot added has-user-test user-test-required User tests have not been completed labels Apr 18, 2024
@keymanapp-test-bot
Copy link

keymanapp-test-bot bot commented Apr 18, 2024

User Test Results

Test specification and instructions

  • TEST_NEW_PROJECT (PASSED): Tested with the attached PR build (Keyman Developer 17.0.310-beta-test-11251) on Windows 11 OS (VM) and here is my observation: 1. Retested issue 11228 with the new build and I was not able to reproduce it. 2. It seems to be working fine with the new build. Thanks. (notes)

Test Artifacts

@keymanapp-test-bot keymanapp-test-bot bot added this to the B17S6 milestone Apr 18, 2024
@mcdurdin mcdurdin linked an issue Apr 18, 2024 that may be closed by this pull request
8 tasks
@bharanidharanj
Copy link

Test Results

  • TEST_NEW_PROJECT (PASSED): Tested with the attached PR build (Keyman Developer 17.0.310-beta-test-11251) on Windows 11 OS (VM) and here is my observation: 1. Retested issue 11228 with the new build and I was not able to reproduce it. 2. It seems to be working fine with the new build. Thanks.

@keymanapp-test-bot keymanapp-test-bot bot removed the user-test-required User tests have not been completed label Apr 18, 2024
Copy link
Contributor

@darcywong00 darcywong00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcdurdin mcdurdin merged commit 630ce3a into beta Apr 22, 2024
5 checks passed
@mcdurdin mcdurdin deleted the fix/developer/11228-no-xmlns-for-child-elements branch April 22, 2024 04:17
@keyman-server
Copy link
Collaborator

Changes in this pull request will be available for download in Keyman version 17.0.312-beta

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(developer): An LDML error occurs after compiling an LDML keyboard
4 participants