fix(core): ldml backspace processing should delete all markers 🙀 #11254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- current code would only delete a single marker and fall through - should loop consuming all markers until a non-marker char is hit
keymanapp-test-bot
bot
added
the
user-test-missing
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
- current code only deletes a single marker and falls through - update the ldml test code, get rid of 'expected character' backspace logic (now that we have context object) - update test cases
…le-marker-on-delete
This was referenced Apr 25, 2024
mcdurdin
approved these changes
Apr 26, 2024
|
@mcdurdin didn't get user tests yet but otherwise ready |
|
@keymanapp-test-bot skip |
keymanapp-test-bot
bot
removed
the
user-test-missing
|
@rc-swag ok go ahead and merge this once the parent is merged.. |
|
Changes in this pull request will be available for download in Keyman version 17.0.315-beta |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
current code would only delete a single marker and fall through
should loop consuming all markers until a non-marker char is hit
needs unit test
needs user test
split from #11172