Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(developer): lazy initialization of test window #11275

Merged
merged 1 commit into from
Apr 22, 2024

Conversation

mcdurdin
Copy link
Member

Fixes #11273.

On some devices, the fetch() would return faster than the remaining script loads, which caused this script error. Lazy initialization should address this.

@keymanapp-test-bot skip

Fixes #11273.

On some devices, the fetch() would return faster than the remaining
script loads, which caused this script error. Lazy initialization should
address this.
@mcdurdin mcdurdin requested a review from darcywong00 as a code owner April 22, 2024 03:57
@keymanapp-test-bot
Copy link

keymanapp-test-bot bot commented Apr 22, 2024

User Test Results

Test specification and instructions

User tests are not required

Test Artifacts

Copy link
Contributor

@darcywong00 darcywong00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcdurdin mcdurdin merged commit d3c2ddf into beta Apr 22, 2024
5 checks passed
@mcdurdin mcdurdin deleted the fix/developer/11273-initdroparea-lazy-init branch April 22, 2024 08:29
@keyman-server
Copy link
Collaborator

Changes in this pull request will be available for download in Keyman version 17.0.312-beta

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(developer): ReferenceError: initDropArea is not defined in Server
3 participants