Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(windows): Changing the tray icon to Application Icon always #11287

Closed
wants to merge 2 commits into from

Conversation

MayuraVerma
Copy link
Contributor

Changing the tray icon to Application Icon always. keymanapp#859
@keymanapp-test-bot keymanapp-test-bot bot added the user-test-missing User tests have not yet been defined for the PR label Apr 22, 2024
@keymanapp-test-bot
Copy link

User Test Results

Test specification and instructions

ERROR: user tests have not yet been defined

@keymanapp-test-bot keymanapp-test-bot bot added this to the B17S6 milestone Apr 22, 2024
@keyman-server
Copy link
Collaborator

This pull request is from an external repo and will not automatically be built. The build must still be passed before it can be merged. Ask one of the team members to make a manual build of this PR.

@darcywong00 darcywong00 changed the title Changing the tray icon to Application Icon always feat(windows): Changing the tray icon to Application Icon always Apr 23, 2024
@@ -650,10 +650,13 @@ procedure TCustomKeymanTrayIcon.SetBalloonIcon(const Value: THandle);

procedure TCustomKeymanTrayIcon.SetDefaultIcon;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be better to have a procedure called SetIcon that will set either the Application Icon or the Keyboard supplied Icon based on a bool value. That bool value is ultimately set by a configuration value in the Keyman Configuration->Options .

@rc-swag
Copy link
Contributor

rc-swag commented Apr 23, 2024

Thank you for this PR. It will need some changes. It should be a configuration option intially to change this behaviour as all the current users are used to the current way it changes.

An Option should be added Keyman Configuration->Options , that allows setting the system tray icon to Keyboard Icon. This way we can allow all the users who do not want this change to select that option.

@darcywong00 darcywong00 modified the milestones: B17S6, A18S1 Apr 28, 2024
@darcywong00 darcywong00 modified the milestones: A18S1, A18S2 May 11, 2024
@mcdurdin
Copy link
Member

This PR is stale, so we'll go ahead and close it and you can re-open when you have addressed @rc-swag's feedback. Thanks!

@mcdurdin mcdurdin closed this May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat user-test-missing User tests have not yet been defined for the PR windows/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants