-
-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(windows): Changing the tray icon to Application Icon always #11287
Conversation
Changing the tray icon to Application Icon always. keymanapp#859
Update KeymanTrayIcon.pas
User Test ResultsTest specification and instructions ERROR: user tests have not yet been defined |
This pull request is from an external repo and will not automatically be built. The build must still be passed before it can be merged. Ask one of the team members to make a manual build of this PR. |
@@ -650,10 +650,13 @@ procedure TCustomKeymanTrayIcon.SetBalloonIcon(const Value: THandle); | |||
|
|||
procedure TCustomKeymanTrayIcon.SetDefaultIcon; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be better to have a procedure called SetIcon that will set either the Application Icon or the Keyboard supplied Icon based on a bool value. That bool value is ultimately set by a configuration value in the Keyman Configuration->Options
.
Thank you for this PR. It will need some changes. It should be a configuration option intially to change this behaviour as all the current users are used to the current way it changes. An Option should be added |
This PR is stale, so we'll go ahead and close it and you can re-open when you have addressed @rc-swag's feedback. Thanks! |
#859