You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change improves the way we detect if we're running a Gnome based UI that needs it's keyboards installed under org.gnome.desktop.input-sources. We use the environment variable XDG_CURRENT_DESKTOP and check if it contains the word gnome. Additionally this change renames is_gnome_shell() to is_gnome_desktop().
✅ GROUP_FOCAL: Ubuntu 20.04 Focal with Gnome Shell and X11
1 tests PASSED
✅ TEST_INSTALL (PASSED): 1. Tested with the attached PR build (Keyman 18.0.21-alpha (package version 18.0.21-1~PR-11292-2776.1+focal1) on Ubuntu Focal 20.04 Linux OS (VM) and here is my observation: 1. Opened Keyman Configuration. 2. Installed the Keyman Keyboard. 3. Verified that the installed keyboard appeared on the Keyboard / language dropdown list in the task bar. (notes)
✅ GROUP_NOBLE_WAYLAND: Ubuntu 24.04 Noble with Gnome Shell and Wayland
1 tests PASSED
✅ TEST_INSTALL (PASSED): 1. Tested with the attached PR build (Keyman 18.0.21-alpha (package version 18.0.21-1~PR-11292-2776.1+noble1) on Ubuntu Noble 24.04 Linux OS (VM) and here is my observation: 1. Opened Keyman Configuration. 2. Installed the Keyman Keyboard. 3. Verified that the installed keyboard appeared on the Keyboard/language dropdown list in the taskbar. (notes)
✅ GROUP_WASTA: Wasta 22.04 with Cinnamon
1 tests PASSED
✅ TEST_INSTALL (PASSED): 1. Tested with the attached PR build (Keyman 18.0.21-alpha (package version 18.0.21-1~PR-11292-2776.1+focal1) on Wasta 22.04 with Cinnamon Linux OS (VM) and here is my observation: 1. Opened Keyman Configuration. 2. Installed the Keyman Keyboard. 3. Verified that the installed keyboard appeared on the Keyboard/language dropdown list in the taskbar.
This change improves the way we detect if we're running a Gnome based
UI that needs it's keyboards installed under
`org.gnome.desktop.input-sources`. We use the environment variable
`XDG_CURRENT_DESKTOP` and check if it contains the word `gnome`.
Additionally this change renames `is_gnome_shell()` to
`is_gnome_desktop()`.
Fixes#11225.
GROUP_FOCAL: Ubuntu 20.04 Focal with Gnome Shell and X11
TEST_INSTALL (PASSED): 1. Tested with the attached PR build (Keyman 18.0.21-alpha (package version 18.0.21-1~PR-11292-2776.1+focal1) on Ubuntu Focal 20.04 Linux OS (VM) and here is my observation: 1. Opened Keyman Configuration. 2. Installed the Keyman Keyboard. 3. Verified that the installed keyboard appeared on the Keyboard / language dropdown list in the task bar.
GROUP_NOBLE_WAYLAND: Ubuntu 24.04 Noble with Gnome Shell and Wayland
TEST_INSTALL (BLOCKED): 1. Got an error message while installed the attached PR build on Ubuntu Noble_Wayland Linux OS. 2. This error prevents further testing on this test.
TEST_INSTALL (PASSED): 1. Tested with the attached PR build (Keyman 18.0.21-alpha (package version 18.0.21-1~PR-11292-2776.1+focal1) on Wasta 22.04 with Cinnamon Linux OS (VM) and here is my observation: 1. Opened Keyman Configuration. 2. Installed the Keyman Keyboard. 3. Verified that the installed keyboard appeared on the Keyboard/language dropdown list in the taskbar.
GROUP_NOBLE_WAYLAND: Ubuntu 24.04 Noble with Gnome Shell and Wayland
TEST_INSTALL (PASSED): 1. Tested with the attached PR build (Keyman 18.0.21-alpha (package version 18.0.21-1~PR-11292-2776.1+noble1) on Ubuntu Noble 24.04 Linux OS (VM) and here is my observation: 1. Opened Keyman Configuration. 2. Installed the Keyman Keyboard. 3. Verified that the installed keyboard appeared on the Keyboard/language dropdown list in the taskbar.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
keymanapp-test-bot
bot
added
has-user-test
user-test-required
ermshiperete
force-pushed
the
fix/linux/11225_environment-detection
branch
from
This change improves the way we detect if we're running a Gnome based UI that needs it's keyboards installed under
org.gnome.desktop.input-sources. We use the environment variableXDG_CURRENT_DESKTOPand check if it contains the wordgnome. Additionally this change renamesis_gnome_shell()tois_gnome_desktop().Fixes #11225.
User Testing
Preparations
The tests should be run on these Linux platforms:
Install build artifacts of this PR
Reboot
Tests
TEST_INSTALL: