Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(web): fixes error on tab, enter when only a single input element is on the page #11470

Merged
merged 2 commits into from
May 30, 2024
Merged

fix(web): fixes error on tab, enter when only a single input element is on the page #11470

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3d0ce74
fix(web): fixes error on tab, enter when only a single input element …
jahorton May 17, 2024
8535f43
Merge branch 'master' into fix/web/error-without-neighbor
mcdurdin May 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion web/src/app/browser/src/defaultBrowserRules.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ export default class DefaultBrowserRules extends DefaultRules {
const contextManager = this.contextManager;
const activeElement = contextManager.activeTarget?.getElement();
const nextElement = contextManager.page.findNeighboringInput(activeElement, back);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The function can explicitly return null, yet we weren't null-guarding on the result.

nextElement.focus();
nextElement?.focus();
}

switch(code) {
Expand Down
Loading