Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(developer): handle invalid default project path in options 🍒 🏠 #11556

Conversation

mcdurdin
Copy link
Member

Cherry-pick of #11555.

If a relative or otherwise invalid path is given for default project path in .keymandeveloper/options.json, then this will reset the path to the default of %Documents%/Keyman Developer/Projects.

Fixes: #11554
Fixes: KEYMAN-DEVELOPER-1ZB

@keymanapp-test-bot skip

If a relative or otherwise invalid path is given for `default project
path` in .keymandeveloper/options.json, then this will reset the path
to the default of `%Documents%/Keyman Developer/Projects`.

Fixes: #11554
Fixes: KEYMAN-DEVELOPER-1ZB
@mcdurdin mcdurdin requested a review from darcywong00 as a code owner May 27, 2024 05:17
@keymanapp-test-bot
Copy link

User Test Results

Test specification and instructions

User tests are not required

@keymanapp-test-bot keymanapp-test-bot bot changed the title fix(developer): handle invalid default project path in options 🍒 fix(developer): handle invalid default project path in options 🍒 🏠 May 27, 2024
@keymanapp-test-bot keymanapp-test-bot bot added this to the A18S3 milestone May 27, 2024
@github-actions github-actions bot added developer/ developer/ide/ cherry-pick Change already merged into another (stable) branch fix labels May 27, 2024
@mcdurdin mcdurdin merged commit 694837c into stable-17.0 May 31, 2024
5 checks passed
@mcdurdin mcdurdin deleted the fix/developer/cherry-pick/11554-handle-invalid-default-project-path branch May 31, 2024 06:06
@keyman-server
Copy link
Collaborator

Changes in this pull request will be available for download in Keyman version 17.0.326

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick Change already merged into another (stable) branch developer/ide/ developer/ fix stable
Projects
None yet
3 participants