Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(developer): add context/options #11566

Merged
merged 9 commits into from
Sep 25, 2024
Merged

Conversation

Nnyny
Copy link
Collaborator

@Nnyny Nnyny commented May 27, 2024

partial fix of: #2131

@keymanapp-test-bot skip

@keymanapp-test-bot keymanapp-test-bot bot added the user-test-missing User tests have not yet been defined for the PR label May 27, 2024
@keymanapp-test-bot
Copy link

keymanapp-test-bot bot commented May 27, 2024

User Test Results

Test specification and instructions

User tests are not required

@keymanapp-test-bot keymanapp-test-bot bot added this to the A18S3 milestone May 27, 2024
@keyman-server
Copy link
Collaborator

This pull request is from an external repo and will not automatically be built. The build must still be passed before it can be merged. Ask one of the team members to make a manual build of this PR.

@keymanapp-test-bot keymanapp-test-bot bot removed the user-test-missing User tests have not yet been defined for the PR label May 28, 2024
Copy link
Member

@mcdurdin mcdurdin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good start -- I have some suggested changes. Thanks!

Comment on lines 395 to 397
<Control Name="chkShowStartupDialog" Title="General tab">
<p></p>
</Control>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see a few examples where you haven't added content -- is this because the content is missing on help.keyman.com? We should aim to update both in that situation!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, there's no info on help.keyman.com.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What can I do with missing contents?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to write some content. Do you want to do that with @Meng-Heng or would you prefer I write something up?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like you to write for us cause it would be more accurate. Also, for some functions that no longer appear in 17.0 like chkShowStartupDialog and chkAllowMultipleInstances, can I just delete it?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like you to write for us cause it would be more accurate.

OK. I will work on it when I get some time!

Also, for some functions that no longer appear in 17.0 like chkShowStartupDialog and chkAllowMultipleInstances, can I just delete it?

Yes

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noted! I already removed it.

developer/src/tike/xml/help/contexthelp.xml Outdated Show resolved Hide resolved
developer/src/tike/xml/help/contexthelp.xml Outdated Show resolved Hide resolved
developer/src/tike/xml/help/contexthelp.xml Outdated Show resolved Hide resolved
developer/src/tike/xml/help/contexthelp.xml Outdated Show resolved Hide resolved
<p>Rebuilds the Unicode character database from source unicodedata.txt and blocks.txt.
These files can be downloaded from the Unicode website at http://www.unicode.org/ucd/.
This lets you update the character map with a newer version of Unicode.
Keyman Developer 10.0 was released with Unicode version 10.0 data.</p>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line is very old :-) Is it also old on help.keyman.com?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I got it from developer 17.0.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's update that to Keyman Developer 17.0 was released with Unicode version 15.1.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noted!

@mcdurdin mcdurdin modified the milestones: A18S3, A18S4 Jun 7, 2024
@darcywong00 darcywong00 modified the milestones: A18S4, A18S5 Jun 21, 2024
@darcywong00 darcywong00 modified the milestones: A18S5, A18S6 Jul 8, 2024
@darcywong00 darcywong00 modified the milestones: A18S6, A18S7 Jul 19, 2024
@darcywong00 darcywong00 modified the milestones: A18S7, A18S8 Aug 2, 2024
@darcywong00 darcywong00 modified the milestones: A18S8, A18S9 Aug 17, 2024
@darcywong00 darcywong00 modified the milestones: A18S9, A18S10 Aug 31, 2024
@darcywong00 darcywong00 modified the milestones: A18S10, A18S11 Sep 14, 2024
@Nnyny
Copy link
Collaborator Author

Nnyny commented Sep 17, 2024

I made some changes. Please review this again, @mcdurdin.

Copy link
Member

@mcdurdin mcdurdin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mcdurdin mcdurdin merged commit 9e6ab2e into keymanapp:master Sep 25, 2024
2 of 3 checks passed
@Nnyny Nnyny deleted the context/options branch September 26, 2024 06:15
@keyman-server
Copy link
Collaborator

Changes in this pull request will be available for download in Keyman version 18.0.118-alpha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants