-
-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(developer): add context/options #11566
Conversation
User Test ResultsTest specification and instructions User tests are not required |
This pull request is from an external repo and will not automatically be built. The build must still be passed before it can be merged. Ask one of the team members to make a manual build of this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a good start -- I have some suggested changes. Thanks!
<Control Name="chkShowStartupDialog" Title="General tab"> | ||
<p></p> | ||
</Control> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see a few examples where you haven't added content -- is this because the content is missing on help.keyman.com? We should aim to update both in that situation!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, there's no info on help.keyman.com.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What can I do with missing contents?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need to write some content. Do you want to do that with @Meng-Heng or would you prefer I write something up?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like you to write for us cause it would be more accurate. Also, for some functions that no longer appear in 17.0 like chkShowStartupDialog
and chkAllowMultipleInstances
, can I just delete it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like you to write for us cause it would be more accurate.
OK. I will work on it when I get some time!
Also, for some functions that no longer appear in 17.0 like
chkShowStartupDialog
andchkAllowMultipleInstances
, can I just delete it?
Yes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noted! I already removed it.
<p>Rebuilds the Unicode character database from source unicodedata.txt and blocks.txt. | ||
These files can be downloaded from the Unicode website at http://www.unicode.org/ucd/. | ||
This lets you update the character map with a newer version of Unicode. | ||
Keyman Developer 10.0 was released with Unicode version 10.0 data.</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line is very old :-) Is it also old on help.keyman.com?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I got it from developer 17.0.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's update that to Keyman Developer 17.0 was released with Unicode version 15.1.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noted!
Co-authored-by: Marc Durdin <[email protected]>
Co-authored-by: Marc Durdin <[email protected]>
I made some changes. Please review this again, @mcdurdin. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Changes in this pull request will be available for download in Keyman version 18.0.118-alpha |
partial fix of: #2131
@keymanapp-test-bot skip