Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(developer): rename to analyzer-messages.ts #12017

Merged
merged 1 commit into from
Jul 27, 2024

Conversation

mcdurdin
Copy link
Member

@mcdurdin mcdurdin commented Jul 25, 2024

Fixes #10254.
Replaces #11315.

tsc 5.4 seems to resolve this. See follow-up PR #12028 for resolution.

@keymanapp-test-bot skip

Fixes #10254.

A full clean and build resolved this, so seems likely the rename caused
some intermediate file to break?
@mcdurdin mcdurdin requested a review from darcywong00 as a code owner July 25, 2024 08:48
@keymanapp-test-bot
Copy link

User Test Results

Test specification and instructions

User tests are not required

darcywong00

This comment was marked as duplicate.

Copy link
Contributor

@darcywong00 darcywong00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.
CI failed though?

@mcdurdin mcdurdin merged commit ed6374c into master Jul 27, 2024
4 of 5 checks passed
@mcdurdin mcdurdin deleted the chore/developer/10254-analyzer-messages branch July 27, 2024 01:34
@keyman-server
Copy link
Collaborator

Changes in this pull request will be available for download in Keyman version 18.0.77-alpha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore(developer): rename kmc-analyzer/messages.ts to kmc-analyzer/analyzer-messages.ts
3 participants