refactor(developer): improve the callbacks for kmcmplib 🌋 #12031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Removes redundant calls * Uses C++ classes on the interface side * Removes global callbacks from the Javascript side In preparation for cleanup of compiler messages
keymanapp-test-bot
bot
added
the
user-test-missing
User Test ResultsTest specification and instructions User tests are not required |
keymanapp-test-bot
bot
removed
the
user-test-missing
mcdurdin
changed the title
jahorton
reviewed
Jul 31, 2024
Comment on lines
+276
to
+285
| const compiler = this; | ||
| const wasm_callbacks = Module.WasmCallbackInterface.implement({ | ||
| message: function(message: KmnCompilerResultMessage) { | ||
| compiler.callbacks.reportMessage(mapErrorFromKmcmplib(message.lineNumber, message.errorCode, message.message)); | ||
| }, | ||
| loadFile: function(filename: string, baseFilename: string): number[] { | ||
| const data: Uint8Array = compiler.callbacks.loadFile(compiler.callbacks.resolveFilename(baseFilename, filename)); | ||
| return data ? Array.from(data) : null; | ||
| } | ||
| }); |
There was a problem hiding this comment.
Is there a reason to not use arrow functions here?
There was a problem hiding this comment.
Not really, no, but it's just syntactic sugar right?
Comment on lines
+58
to
59
| std::copy(bufvec.begin(), bufvec.end(), infile); | ||
| infile[sz] = 0; // zero-terminate for safety, not technically needed but helps avoid memory bugs |
There was a problem hiding this comment.
Null-termination after copying the string?
jahorton
approved these changes
Aug 2, 2024
| message: function(message: KmnCompilerResultMessage) { | ||
| compiler.callbacks.reportMessage(mapErrorFromKmcmplib(message.lineNumber, message.errorCode, message.message)); | ||
| }, | ||
| loadFile: function(filename: string, baseFilename: string): number[] { |
There was a problem hiding this comment.
Was loadFileCallback. Obviously, it's been dramatically simplified from the original.
(I didn't realize this before; only learned via paired review. Documenting this for future reference.)
Base automatically changed from
refactor/developer/kmcmplib-compiler-errors
to
master
August 3, 2024 02:07
|
Changes in this pull request will be available for download in Keyman version 18.0.81-alpha |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a significant rework of the callbacks from kmcmplib -- using
std::vectorand other C++ std classes to remove memory management calls and simplify the WASM bindings.loadFileProc(akaloadFilein the new pattern)In preparation for cleanup of compiler messages.
Relates-to: #10866
@keymanapp-test-bot skip