chore(core): explicitly add dependency in core/build.sh
#12050
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a dependency problem with building Core after cleaning the `core` directory: `core` depends on `common/web/types` which in turn depends on `core/include/ldml`. If the result of building `common/web/types` still exists, we didn't build `core/include/ldml` which lead to failure building `core`. Explicitly adding the reference to `core` fixes it.
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
`jq.inc.sh` gets sourced in `build-utils-ci.inc.sh` which in turn is sourced from `common/include/ldml/build.sh`, so we have to include it in the source package. Strange that we got around without it before...
|
This would require to include quite a bit more (unused) source code files to the Debian source package. Doesn't seem to be worth spending more time on this. Workaround: run |
|
This circular dependency is on my radar. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a dependency problem with building Core after cleaning the
coredirectory:coredepends oncommon/web/typeswhich in turn depends oncore/include/ldml. If the result of buildingcommon/web/typesstill exists, we previously didn't buildcore/include/ldmlwhich lead to a failure buildingcore. Explicitly adding the reference tocorefixes it.@keymanapp-test-bot skip