fix(web): unrevert #11258, leaving OSK hidden before instructed to display 🍒 🏠

[jahorton]

Cherry-pick-of: #12049

User Testing

TEST_REPRO: Attempt to reproduce #11962 using Keyman for Android.

• Install the package provided within that issue.
• Force-quit the app.
• Relaunch the app.
  • If the issue is not properly fixed, an error notification will appear on app-relaunch.

TEST_ANDROID: Do simple general-use testing with Keyman for Android and report back if any odd behaviors occur.

TEST_IOS: Do simple general-use testing with Keyman for iOS and report back if any odd behaviors occur.

TEST_WEB: Do simple general-use testing with the "Test unminified Web" test page and report back if any odd behaviors occur.

TEST_DEV_SERVER: Use Keyman Developer's web-keyboard testing page and verify that it still works correctly. (We're mostly checking to see that this doesn't result in an immediate, obvious break.)

[keymanapp-test-bot]

User Test Results

Test specification and instructions

• ✅ TEST_REPRO (PASSED) (notes)
• ✅ TEST_ANDROID (PASSED) (notes)
• ✅ TEST_IOS (PASSED) (notes)
• ✅ TEST_WEB (PASSED) (notes)
• ✅ TEST_DEV_SERVER (PASSED) (notes)

[dinakaranr]

Test Results

I tested this issue with the attached "Keyman 17.0.329" build on the Android 14 & iPhone, web(Chrome & Firefox), and keyboard developer. Here is my observation.

• TEST_REPRO (passed):

1. Install the "Keyman 17.0.329-test-12058" build.
2. Relaunch the app after force quit.
3. No error notification appears when forced to quit the app.

• TEST_ANDROID (passed):

1. Installed the "Keyman-17.0.329.apk" file and gave all permissions to the application.
2. Checked the "Enable Keyman as system-wide keyboard" and set the keyboard as the default keyboard box on the settings page.
3. Open the Keyman app. Enable the "Predictions" and install the "Dictionary."
4. Added a sentence to the notepad and Chrome (search).
5. Enter a word and observe that the words are suggested on the banner.
6. The keyboard works on portrait and landscape viewport. Keyboard set as system keyboard.
7. Installed/uninstalled multiple keyboards.
   It looks like it was expected.

• TEST_IOS (passed):

1. Installed the "Keyman-17.0.329" build from the testflight app and gave all permissions to the application.
2. Checked the "Enable Keyman as system-wide keyboard" and set the keyboard as the default keyboard box on the settings page.
3. Open the Keyman app. Enable the "Predictions" and install the "Dictionary."
4. Added a sentence to the notepad and Chrome (search).
5. Enter a word. Observe that the words are suggested on the banner.
6. The keyboard works on portrait and landscape viewports. Keyboard set as system keyboard.
7. Installed/uninstalled multiple keyboards.
   It looks like it was expected.

• TEST_WEB (passed):

1. Navigate to the "Tests unminified Keymanweb" --> "KeymanWeb Sample Page - Unminified Source" pages.
2. "English - English": It works well in the text box and OSK keyboard.
3. "Lao - Lao Basic": It works well in the text box and OSK keyboard.
4. "English - Classic 10-key": OSK board appears but it is blank now. An alert window appears for very few seconds.
5. It works in Khmer and French keyboards too. Thank you.

TEST_DEV_SERVER (passed):

1. Added the Amharic & Cameroon keyboards loaded the .kmn, and pressed F7 to compile.
2. SUITE_DEBUGGER: Test new core-based debugger - Compile and recompile the keyboard
3. SUITE_SERVER: Test new Keyman Developer Server - Keyboard launched on the browser with OSK.
   I tested the above two test suites and work as per expected. Thanks.

[mcdurdin]

LGTM

(process note: it looks like you had based this PR on HEAD of stable-17.0 and not on the parent PR branch originally -- which was based on HEAD~1, so I had to merge stable-17.0 in after merging parent to remove unrelated files from this PR history)

[mcdurdin]

4. "English - Classic 10-key": OSK board appears but it is blank now. An alert window appears for very few seconds.

I missed this before merging (I have not yet done the 17.0 stable build). Is this new behaviour? Or does it happen in the same way on 17.0.328? If you can reproduce this, can you share a video?

[keyman-server]

Changes in this pull request will be available for download in Keyman version 17.0.329