refactor(developer): move kmcmplib message construction to kmc-kmn 🌋 #12059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove compiler message definitions from kmcmplib * Add parameterization to compiler message structures * Translate parameters for existing parameterized messages (except for `ERROR_InvalidToken`, which requires a bigger refactor of `GetXStringImpl()` and many friends) * Add columnNumber to message structures (not yet used in kmc-kmn) * Add filename to message structures (not yet used in kmcmplib) * Rename `INFO_Info` to `INFO_MinimumCoreEngineVersion` and `INFO_MinimumEngineVersion` to `INFO_MinimumWebEngineVersion` Relates-to: #10866
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
jahorton
approved these changes
Aug 1, 2024
Comment on lines
+39
to
+43
| #define MESSAGE_SEVERITY_MASK 0x00F00000 // includes reserved bits, 16 possible severity levels | ||
| #define MESSAGE_ERROR_MASK 0x000FFFFF // error | namespace | ||
| #define MESSAGE_NAMESPACE_MASK 0x000FF000 // 256 possible namespaces | ||
| #define MESSAGE_BASEERROR_MASK 0x00000FFF // error code, 2,048 possible error codes per namespace | ||
| #define MESSAGE_RESERVED_MASK 0xFF000000 // do not use these error values at this time |
Base automatically changed from
refactor/developer/kmcmplib-yak-shave-more-bools
to
master
August 3, 2024 02:13
mcdurdin
deleted the
refactor/developer/kmcmplib-construct-messages-in-kmc-kmn
branch
|
Changes in this pull request will be available for download in Keyman version 18.0.81-alpha |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ERROR_InvalidToken, which requires a bigger refactor ofGetXStringImpl()and many friends)INFO_InfotoINFO_MinimumCoreEngineVersionandINFO_MinimumEngineVersiontoINFO_MinimumWebEngineVersionFixes: #10866
@keymanapp-test-bot skip