chore(developer): support filename field in kmcmplib compiler messages 🌋 #12061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
ermshiperete
approved these changes
Jul 30, 2024
| //TODO: message.filename = | ||
| (*kmcmp::msgproc)(message, msgprocContext); | ||
| message.filename = kmcmp::messageFilename; | ||
| (*kmcmp::msgproc)(message, kmcmp::msgprocContext); |
There was a problem hiding this comment.
Do we have to check that kmcmp::msgproc != nullptr ?
There was a problem hiding this comment.
Good question. This is done in CompilerInterfaces.cpp:
keyman/developer/src/kmcmplib/src/CompilerInterfaces.cpp
Lines 27 to 30 in 897697d
Base automatically changed from
refactor/developer/kmcmplib-rename-error-message-functions
to
master
August 3, 2024 10:56
|
Changes in this pull request will be available for download in Keyman version 18.0.81-alpha |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates-to: #10866
@keymanapp-test-bot skip