chore(common): use nvm to select version of node for builds 🍒 🏠
#12074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Used by default only on build agents. See docs/build/node.md and resources/build/_builder_nvm.sh for documentation of this change. Fixes: #11376
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
keymanapp-test-bot
bot
changed the title
nvm to select version of node for builds 🍒nvm to select version of node for builds 🍒 🏠
github-actions
bot
added
common/
common/resources/
jahorton
approved these changes
Aug 1, 2024
There was a problem hiding this comment.
So... looks like we fully dropped the changes affecting the docs/ folder. I guess there would be some pain due to divergence already existing there between v17 and v18. (Just noting the reason that the changeset deltas are so different between this and its alpha-targeting variant.)
As noted in the PR description, yes. |
|
Changes in this pull request will be available for download in Keyman version 17.0.329 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Used by default only on build agents. See docs/build/node.md and resources/build/_builder_nvm.sh on master (18.0) branch for documentation of this change -- documentation only added on master.
Specifies node v18.17.0.
Fixes: #11376
Cherry-pick-of: #12069
@keymanapp-test-bot skip