-
-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(developer): use npm or local source for server addons instead of github references #12090
refactor(developer): use npm or local source for server addons instead of github references #12090
Conversation
Server is failing to start on the build associated with 38d043c:
|
Test ResultsI tested the PR #12090 task today using the Keyman 18.0.81-alpha-test-12090 build. I repeatedly get the confirm dialog after clicking the "Test Keyboard on Web" button. Hence, I am unable to launch the keyboard on the browser (localhost:8008). I observed this behavior on Windows 10 and 11 OSs. So, I am unable to proceed with the testing. Hence, I failed this PR. Thank you.
|
99822b6
to
2fc6a5b
Compare
…d of github references Brings trayicon source into the repository, as the source repo appears to be dead. Updates console source to latest version on npm. Fixes: #12077
2fc6a5b
to
2814ac9
Compare
Note: force push to cleanup commit history on developer/src/kmc/test/fixtures/get-last-git-commit-date/README.md, which was involved in a throwaway non-merge commit (d8986be), breaking the unit test. (Yeah, this test is a bit fragile, I guess we could mock the call to |
Latest build:
|
The way that Server is built for local distribution does not currently handle transitive dependencies for @keymanapp dependencies well. So, this adds four dependencies from @keymanapp/developer-utils to Server so that they will be available in the packaged deployment. A future improvement could be to package developer-utils using npm packaging tools, but these struggled with bundling monorepo dependencies in the past also.
…ps to Server Fixes: #12077
@dinakaranr I have resolved the issues that were blocking user test. Would you be able to re-test? Thanks! @keymanapp-test-bot retest all |
Test ResultsI tested this issue with the attached "Keymandeveloper-18.0.87-Alpha-test-12090" build on the Windows 10 and 11 OS environments: Here is my observation.
|
Thank you for the test @dinakaranr and picking this up. It turns out that this issue is already being tracked: As the problem is not new to this PR, and is not major I will mark this as 'SKIPPED' and go ahead and merge: TEST_SERVER_CONSOLE_WINDOW (skipped) |
Changes in this pull request will be available for download in Keyman version 18.0.89-alpha |
Brings trayicon source into the repository, as the source repo appears to be dead. Updates console source to latest version on npm.
Opted not to bring the source into the repo rather than keep in a separate repo because npm doesn't behave well with git/https links, and we don't want to publish yet another package.
Fixes: #12077
User Testing