refactor(web): move lm-worker → worker-thread 🏗️
#12150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
User Test ResultsTest specification and instructions User tests are not required |
ermshiperete
force-pushed
the
refactor/web/12147_types
branch
from
e7a3718 to
8fbec5f
Compare
ermshiperete
force-pushed
the
refactor/web/12148_worker-thread
branch
from
3ccd305 to
864a3bc
Compare
ermshiperete
force-pushed
the
refactor/web/12147_types
branch
from
8fbec5f to
6a6b7c4
Compare
ermshiperete
force-pushed
the
refactor/web/12148_worker-thread
branch
from
864a3bc to
e8572e3
Compare
ermshiperete
force-pushed
the
refactor/web/12147_types
branch
from
6a6b7c4 to
6000f6d
Compare
ermshiperete
force-pushed
the
refactor/web/12148_worker-thread
branch
from
e8572e3 to
28c2977
Compare
ermshiperete
force-pushed
the
refactor/web/12147_types
branch
from
6000f6d to
392a0fb
Compare
ermshiperete
force-pushed
the
refactor/web/12148_worker-thread
branch
from
28c2977 to
08e0d30
Compare
ermshiperete
force-pushed
the
refactor/web/12147_types
branch
from
392a0fb to
78857d9
Compare
Move `common/web/lm-worker/` → `web/src/engine/predictive-text/worker-thread/`. Fixes: #12148
ermshiperete
force-pushed
the
refactor/web/12148_worker-thread
branch
from
08e0d30 to
ea62ac2
Compare
jahorton
approved these changes
Aug 19, 2024
|
Something I noticed from using the latest changes from this PR's ancestors - please run an (This goes for other move ____ -> ____ 🏗️ PRs too.) |
Addresses code review comments
|
Ahh, that's how you do it 😄 Done. |
|
Changes in this pull request will be available for download in Keyman version 18.0.92-alpha |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move
common/web/lm-worker/→web/src/engine/predictive-text/worker-thread/.Fixes: #12148
@keymanapp-test-bot skip