-
-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(android): Add menu to specify long-press delay #12170
Conversation
User Test Results |
Test ResultsI tested this issue with the attached "Keyman 18.0.88-alpha-test-12170" build on the Android 14 physical device and Android 9(emulator) Here is my observation.
0.5s is the minimum time and 1.5s maximum time. I can alter the timing and make it available when I reopen the app. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, nits only
android/KMAPro/kMAPro/src/main/java/com/tavultesoft/kmapro/AdjustLongpressDelayActivity.java
Outdated
Show resolved
Hide resolved
…ustLongpressDelayActivity.java Co-authored-by: Marc Durdin <[email protected]>
Changes in this pull request will be available for download in Keyman version 18.0.93-alpha |
Addresses the UI portion of #877.
A separate PR will integrate passing the custom long-press duration into KeymanWeb.
The slider in the menu has discrete positions from [0,7] and correspond to long-press durations 0.3s to 1.5s.
Internally, they code keeps track of the current long-press delay as milliseconds, and the default KeymanWeb duration is 500ms.
Screenshots
The menu to adjust the long-press delay is accessed in Keyman Settings
Position at default 0.5s
Position at 1.3s
User Testing
Setup - Install the PR build of Keyman for Android