Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: merge master into linux-mcompile #12172

Merged
merged 143 commits into from
Aug 13, 2024
Merged

chore: merge master into linux-mcompile #12172

merged 143 commits into from
Aug 13, 2024

Conversation

keyman-server
Copy link
Collaborator

mcdurdin and others added 30 commits June 12, 2024 16:31
@mcdurdin
refactor(developer): move developer-utils files into src/ and sub-folder
4ed88d8 
In preparation for moving source file types into developer-utils, move
the existing developer-utils files into src/ and src/utils subfolders.
@mcdurdin
refactor(common): move kpj-related files into developer-utils
9cf09a5 
Relates to #9665.
@mcdurdin
refactor(common): move kpj test fixtures and cleanup post-move
74e2a8c 
Moves the kpj test fixtures into developer-utils, moves from let to
const in code where required by eslint, and reduces the coverage
threshold in order to get tests to pass for developer-utils.
@mcdurdin
chore(common): reduce c8 threshold for common-types
b2c4979 
As we move some better-tested areas out of common-types, it looks like
our overall coverage goes down.
@mcdurdin
chore(developer): update xml2js reference for kpj-file-reader
185c020
@mcdurdin
chore(developer): fixup reference to xml2js
071fe5c
@mcdurdin
refactor(common): move kps-file.ts to @keymanapp/developer-utils
de9ab21 
Part of #9665.
@mcdurdin
refactor(common): move kvks-file to @keymanapp/developer-utils
1c74d9d 
Relates to #9665
@mcdurdin
chore(common): reduce c8 threshold for common-types by 1% after movin…
cdbcbe7 
…g kvk-file
@mcdurdin
refactor(common): fixup tests for kvks-file
f6105d8
@mcdurdin
chore(common): reduce threshold for c8 to 70%
a1d94dc
@mcdurdin
refactor(common): move .keyman-touch-layout reader/writer to @keymana…
09ee827 
…pp/developer-utils

Relates to #9665
@darcywong00
fix(android/engine): Parse keyboards.json for FirstVoices app
4c5b621
@jahorton
change(common/models): change model tokenization to also tokenize whi…
21d21fb 
…tespace
@darcywong00
Merge branch 'master' into fv-all/keyboards-json
2718f36
@jahorton
feat(web): add support for transform tokenization
9618547
@jahorton
change(web): track whitespace-aware tokenization for context + correc…
8f6c2d6 
…tion-search caching
@jahorton
chore(common/models): renames added unit tests
965eeaf
@jahorton
chore(web): pulls forward some changes from child branch
ef4089d
@jahorton
change(web): leverage tokenization to preserve punctuation and whites…
8d40bc3 
…pace when predicting
@jahorton
chore(web): extra cleanup
5322365
@jahorton
docs(web): minor doc tweak
b2c8aea
@jahorton
chore(common/models): address PR review comments re needed comment, c…
b7c7f5a 
…ondition-clarity improvement
@jahorton
chore(web): missed a review improvement spot - let -> const
969f997
@jahorton
fix(common/models): null-guard left-hand token reference for split-to…
092b6f7 
…ken check during tokenization
@jahorton
chore(web): Merge branch 'change/common/models/tokenization' into fea…
fad3b1c 
…t/web/transform-tokenization
@jahorton
chore(web): Merge branch 'feat/web/transform-tokenization' into chang…
cfbf973 
…e/web/full-context-tokenization-tracking
@jahorton
chore(web): Merge branch 'change/web/full-context-tokenization-tracki…
37d3487 
…ng' into change/web/tokenization-awareness-for-predictions
@jahorton
fix(web): prevents correction from deleting tokens
612adf6
@jahorton
chore(web): implement optional-chaining PR suggestion
a966b7b
mcdurdin
mcdurdin approved these changes Aug 13, 2024
View reviewed changes
Copy link
Member

@mcdurdin mcdurdin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@mcdurdin mcdurdin merged commit c5088cc into epic/linux-mcompile Aug 13, 2024
77 checks passed
@mcdurdin mcdurdin deleted the chore/merge-master-into-linux-mcompile branch August 13, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcdurdin mcdurdin mcdurdin approved these changes

@rc-swag rc-swag Awaiting requested review from rc-swag rc-swag is a code owner

@ermshiperete ermshiperete Awaiting requested review from ermshiperete ermshiperete is a code owner

@jahorton jahorton Awaiting requested review from jahorton jahorton is a code owner

@darcywong00 darcywong00 Awaiting requested review from darcywong00 darcywong00 is a code owner

@sgschantz sgschantz Awaiting requested review from sgschantz sgschantz is a code owner

@SabineSIL SabineSIL Awaiting requested review from SabineSIL SabineSIL is a code owner

Assignees
No one assigned
Labels
android/app/ android/engine/ android/ chore common/models/templates/ common/models/ common/resources/ Build infrastructure common/web/ common/ developer/compilers/ developer/ docs ios/app/ ios/engine/ ios/ linux/config/ linux/ mac/ oem/fv/android/ oem/fv/ oem/ web/ windows/config/ windows/
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@keyman-server @mcdurdin @darcywong00 @jahorton @ermshiperete @sgschantz