refactor(web): move gesture-recognizer → gesture-processor 🏗️
#12194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
ermshiperete
force-pushed
the
refactor/web/12148_worker-thread
branch
from
08e0d30 to
ea62ac2
Compare
ermshiperete
force-pushed
the
refactor/web/12151_gestures
branch
from
568c324 to
3e59a7c
Compare
ermshiperete
force-pushed
the
refactor/web/12151_gestures
branch
from
3e59a7c to
5435055
Compare
Moves `common/web/gesture-recognizer/` → `web/src/engine/osk/gesture-processor`. Fixes: #12151
`gesture-processor/src/test/auto/browser/web-test-runner.config.mjs` run the tests on iOS and Android. However, if we enable these browsers in `web/src/test/auto/dom/web-test-runner.config.mjs` we get failing tests in osk, therefore these browsers are commented for now.
…n app/browser build
`test.sh` got removed since it did the same as `build.sh test`.
Previously running the tests failed because it couldn't find ICU 70 when running webkit. Ubuntu 24.04 Noble comes with ICU 74. Updating playwright to 1.46 fixes this.
ermshiperete
force-pushed
the
refactor/web/12151_gestures
branch
from
1c2e537 to
e788bf5
Compare
jahorton
approved these changes
Aug 29, 2024
|
Changes in this pull request will be available for download in Keyman version 18.0.101-alpha |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves
common/web/gesture-recognizer/→web/src/engine/osk/gesture-processor.Fixes: #12151
@keymanapp-test-bot skip