Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: merge master into linux-mcompile 🐘 #12209

Merged
merged 45 commits into from
Aug 16, 2024

Conversation

keyman-server
Copy link
Collaborator

ermshiperete and others added 30 commits August 8, 2024 18:25
Move parts of `common/web/keyboard-processor/` →
`web/src/engine/js-processor/`.

Note this temporarily disable tests for keyboard-processor which depend on
js-processor, until #12110 is fixed.

Fixes: #12067
…d of github references

Brings trayicon source into the repository, as the source repo appears
to be dead. Updates console source to latest version on npm.

Fixes: #12077
The way that Server is built for local distribution does not currently
handle transitive dependencies for @keymanapp dependencies well. So,
this adds four dependencies from @keymanapp/developer-utils to Server so
that they will be available in the packaged deployment.

A future improvement could be to package developer-utils using npm
packaging tools, but these struggled with bundling monorepo dependencies
in the past also.
The Windows Clipboard Win+V key event emits Ctrl+V after rewriting the
clipboard, in order to trigger a Paste action in the active app.
However, the Ctrl key event has been given a scan code value of zero by
Windows Clipboard, which was confusing the Keyman Developer Debugger,
causing it to process Ctrl as an unrecognized key rather than as a
modifier, and leading to an unsupported state.

This is a fix for the immediate issue. We could do more to improve
resilience such that `km_core_state_debug_items()` can never end up with
this exception when `km_core_process_event()` has returned true.

Fixes: #11978
Fixes: KEYMAN-DEVELOPER-20W
move parts of `common/web/keyboard-processor/` →
`web/src/engine/keyboard/`.

Fixes: #12110
- move `systemStore.ts` → `js-processor`
- move `keyEventSource.interface.ts` → `osk`
- move `defaultRules.ts` → back to `keyboard-processor`
- in `KeyboardProcessor` pass `ruleBehavior` as parameter to `forAny`,
  looks like that accidentally got omitted previously

Addresses code review comments.
Addresses code review comments.
Linux' file system is case-sensitive. This change fixes building
`lm-worker` on case-sensitive systems.
…ove-git-npm-deps

refactor(developer): use npm or local source for server addons instead of github references
…can-code-if-injected-key-event-doesnt-provide-it

fix(developer): fix crash with Windows Clipboard by ignoring zero scan code in debugger
…-sil-logo

chore(developer): update SIL logo
Some tests test functionality defined in `js-processor`, so we move
these to the appropriate location. Addresses code review comments.
- move `outputTarget.ts` → `js-processor`
- move `deadkeys.ts` → `js-processor`
- move `stringDivergence.ts` → `js-processor`
- split `Mock` into `mock.ts`
- create `keyboard/outputTarget.interface.ts`
auto: increment master version to 18.0.90
ermshiperete and others added 11 commits August 15, 2024 08:42
fix(web): allow `lm-worker` to build on Linux
refactor(web): move remaining parts of `keyboard-processor` → `keyboard` 🏗️
Move `web/src/engine/package-cache/` →
`web/src/engine/keyboard-storage/`.

Fixes: #12132
This moves `common/predictive-text/` →
`web/src/engine/predictive-text/worker-main/`.

This also moves `common/test/predictive-text/` →
`web/src/test/manual/predictive-text/`. Note though that this testing
tool is still broken.

Fixes: #12134
docs: update .kmx documentation around bitmaps, modifier state
…storage

refactor(web): rename `package-cache` → `keyboard-storage` 🏗️
auto: increment master version to 18.0.91
refactor(web): move `predictive-text` → `worker-main` 🏗️
fix(web): restore flick functionality
Copy link
Member

@mcdurdin mcdurdin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@mcdurdin mcdurdin merged commit 15fa5ff into epic/linux-mcompile Aug 16, 2024
28 of 40 checks passed
@mcdurdin mcdurdin deleted the chore/merge-master-into-linux-mcompile branch August 16, 2024 07:30
@keymanapp-test-bot
Copy link

User Test Results

Test specification and instructions

User tests are not required

@keymanapp-test-bot keymanapp-test-bot bot changed the title chore: merge master into linux-mcompile chore: merge master into linux-mcompile 🐘 Aug 16, 2024
@keymanapp-test-bot keymanapp-test-bot bot added this to the A18S8 milestone Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants