-
-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: merge master into linux-mcompile 🐘 #12209
Merged
mcdurdin
merged 45 commits into
epic/linux-mcompile
from
chore/merge-master-into-linux-mcompile
Aug 16, 2024
Merged
chore: merge master into linux-mcompile 🐘 #12209
mcdurdin
merged 45 commits into
epic/linux-mcompile
from
chore/merge-master-into-linux-mcompile
Aug 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d of github references Brings trayicon source into the repository, as the source repo appears to be dead. Updates console source to latest version on npm. Fixes: #12077
The way that Server is built for local distribution does not currently handle transitive dependencies for @keymanapp dependencies well. So, this adds four dependencies from @keymanapp/developer-utils to Server so that they will be available in the packaged deployment. A future improvement could be to package developer-utils using npm packaging tools, but these struggled with bundling monorepo dependencies in the past also.
…ps to Server Fixes: #12077
The Windows Clipboard Win+V key event emits Ctrl+V after rewriting the clipboard, in order to trigger a Paste action in the active app. However, the Ctrl key event has been given a scan code value of zero by Windows Clipboard, which was confusing the Keyman Developer Debugger, causing it to process Ctrl as an unrecognized key rather than as a modifier, and leading to an unsupported state. This is a fix for the immediate issue. We could do more to improve resilience such that `km_core_state_debug_items()` can never end up with this exception when `km_core_process_event()` has returned true. Fixes: #11978 Fixes: KEYMAN-DEVELOPER-20W
move parts of `common/web/keyboard-processor/` → `web/src/engine/keyboard/`. Fixes: #12110
- move `systemStore.ts` → `js-processor` - move `keyEventSource.interface.ts` → `osk` - move `defaultRules.ts` → back to `keyboard-processor` - in `KeyboardProcessor` pass `ruleBehavior` as parameter to `forAny`, looks like that accidentally got omitted previously Addresses code review comments.
Addresses code review comments.
Linux' file system is case-sensitive. This change fixes building `lm-worker` on case-sensitive systems.
…ove-git-npm-deps refactor(developer): use npm or local source for server addons instead of github references
…can-code-if-injected-key-event-doesnt-provide-it fix(developer): fix crash with Windows Clipboard by ignoring zero scan code in debugger
…-sil-logo chore(developer): update SIL logo
Addresses: #12163#issuecomment-2287675497
Some tests test functionality defined in `js-processor`, so we move these to the appropriate location. Addresses code review comments.
- move `outputTarget.ts` → `js-processor` - move `deadkeys.ts` → `js-processor` - move `stringDivergence.ts` → `js-processor` - split `Mock` into `mock.ts` - create `keyboard/outputTarget.interface.ts`
auto: increment master version to 18.0.90
fix(web): allow `lm-worker` to build on Linux
refactor(web): move remaining parts of `keyboard-processor` → `keyboard` 🏗️
Move `web/src/engine/package-cache/` → `web/src/engine/keyboard-storage/`. Fixes: #12132
This moves `common/predictive-text/` → `web/src/engine/predictive-text/worker-main/`. This also moves `common/test/predictive-text/` → `web/src/test/manual/predictive-text/`. Note though that this testing tool is still broken. Fixes: #12134
docs: update .kmx documentation around bitmaps, modifier state
…storage refactor(web): rename `package-cache` → `keyboard-storage` 🏗️
auto: increment master version to 18.0.91
Co-authored-by: Joshua Horton <[email protected]>
refactor(web): move `predictive-text` → `worker-main` 🏗️
fix(web): restore flick functionality
keyman-server
requested review from
ermshiperete,
jahorton,
darcywong00 and
mcdurdin
as code owners
August 16, 2024 07:29
github-actions
bot
added
web/
developer/
linux/
common/
common/web/
developer/ide/
docs
chore
labels
Aug 16, 2024
mcdurdin
approved these changes
Aug 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RSLGTM
User Test ResultsTest specification and instructions User tests are not required |
keymanapp-test-bot
bot
changed the title
chore: merge master into linux-mcompile
chore: merge master into linux-mcompile 🐘
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@keymanapp-test-bot skip