Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(android): Use RTL-aware alignment and padding for layouts 📟 #12225

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

darcywong00
Copy link
Contributor

Part of #12215

Our current minimum Android API is 21

Since Android API 17, there's layout parameters alignParentStart, alignParentEnd, paddingStart, and paddingEnd which are RTL-aware, whereas alignLeft and alignRight are not.

@keymanapp-test-bot skip

@keymanapp-test-bot
Copy link

keymanapp-test-bot bot commented Aug 19, 2024

@darcywong00 darcywong00 changed the title chore(android): Use RTL-aware alignment and padding for layouts chore(android): Use RTL-aware alignment and padding for layouts 📟 Aug 20, 2024
@darcywong00 darcywong00 merged commit 84ede94 into master Aug 21, 2024
6 checks passed
@darcywong00 darcywong00 deleted the chore/android/padding-rtl branch August 21, 2024 02:26
@keyman-server
Copy link
Collaborator

Changes in this pull request will be available for download in Keyman version 18.0.94-alpha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants