-
-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(mac): limit short bundle version string to x.y.z format in info.plist #12233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in info.plist for both input method and engine, remove the framing text so that it just contains the version number triplet Fixes: #12197
keymanapp-test-bot
bot
added
the
user-test-missing
User tests have not yet been defined for the PR
label
Aug 20, 2024
keymanapp-test-bot
bot
removed
the
user-test-missing
User tests have not yet been defined for the PR
label
Aug 20, 2024
keymanapp-test-bot
bot
added
has-user-test
user-test-required
User tests have not been completed
labels
Aug 21, 2024
Test ResultsI tested this issue with the attached "Keyman 18.0.94-alpha-test" build on the MacOS
|
keymanapp-test-bot
bot
removed
the
user-test-required
User tests have not been completed
label
Aug 23, 2024
mcdurdin
approved these changes
Aug 23, 2024
This needs a cherry-pick to stable-17.0, I think. |
The version string looks good in stable-17.0, so I think we're good to make this change for 18 only. |
Changes in this pull request will be available for download in Keyman version 18.0.98-alpha |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the info.plist for both the Keyman Engine and Input Method, remove the framing text so that CFBundleShortVersionString just contains the version string, x.y.z where x, y and z are numeric values.
Fixes: #12197
Fixes: #12130
For background, see discussion in PR #12156 which was addressing the side effect rather than the root cause.
User Testing
TEST_DOWNLOAD_KEYBOARD_VISIBLE_MONTEREY
TEST_DOWNLOAD_KEYBOARD_VISIBLE_OTHER_OS
TEST_DOWNLOAD_AND_INSTALL_KEYBOARD