chore(common): allow build agents to automatically select emsdk version, and enable support for 3.1.60+ 🍒 🏠 #12245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Emscripten 3.1.60 made a breaking change to `BindingType::toWireType` (why is this done in a patch version?) so this change ensures that we can continue to build on 3.1.58 and 3.1.64 (which is needed for #12234), as a bridging strategy. We will need to merge this into 17.0-stable as well so that we can upgrade the build agents to 3.1.64. Relates-to: emscripten-core/emscripten#21692 Relates-to: #12234
The build agents will now automatically install and activate the Emscripten version found in minimum-versions.inc.sh when configuring WASM projects. For developer machines, this behaviour can be enabled by setting the environment variable `KEYMAN_USE_EMSDK` (recommended). Cherry-pick-of: #12243
User Test ResultsTest specification and instructions User tests are not required Test Artifacts |
github-actions
bot
added
developer/
common/
developer/compilers/
common/resources/
keymanapp-test-bot
bot
changed the title
github-actions
bot
added
cherry-pick
mcdurdin
commented
Aug 21, 2024
| @@ -1,31 +1,73 @@ | |||
| # shellcheck shell=bash | |||
| # no hashbang for .inc.sh | |||
|
|
|||
| KEYMAN_MIN_VERSION_EMSCRIPTEN=3.1.58 | |||
There was a problem hiding this comment.
This is in minimum-versions.inc.sh in 18.0
mcdurdin
requested review from
jahorton,
darcywong00 and
rc-swag
as code owners
mcdurdin
deleted the
chore/developer/cherry-pick/emscripten-3.1.60-patch
branch
|
Changes in this pull request will be available for download in Keyman version 17.0.329 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The build agents will now automatically install and activate the Emscripten version found in minimum-versions.inc.sh when configuring WASM projects. For developer machines, this behaviour can be enabled by setting the environment variable
KEYMAN_USE_EMSDK(recommended).Also, Emscripten 3.1.60 made a breaking change to
BindingType::toWireType(why is this done in a patch version?) so this change ensures that we can continue to build on 3.1.58 and 3.1.64 (which is needed for #12234), as a bridging strategy.Relates-to: emscripten-core/emscripten#21692
Relates-to: #12234
Cherry-pick-of: #12243
Cherry-pick-of: #12235
@keymanapp-test-bot skip