refactor(android): Move build-publish.sh to builder script #12351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
User Test ResultsTest specification and instructions User tests are not required Test Artifacts |
github-actions
bot
added
android/
oem/
android/app/
oem/fv/
oem/fv/android/
refactor
labels
Hmm, stable-17.0 doesn't have the refactored builder scripts from #11329 |
mcdurdin
approved these changes
Sep 10, 2024
Co-authored-by: Marc Durdin <[email protected]>
|
Changes in this pull request will be available for download in Keyman version 18.0.108-alpha |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for #12325
This refactors the
build-publish.shscript that publishes the Keyman and FirstVoices apk's to the Play Store into the corresponding builder scripts.I noticed the top level android build.sh script already declares a publish action
keyman/android/build.sh
Line 21 in fdad0ca
But it must be a NOOP.
Will need to update CI configs and 🍒 pick to stable-17.0
@keymanapp-test-bot skip